-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Listbox key sellecting/scrolling, DX9 example fix + VC++ 2008 compilation fix. #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks. I can't merge this at once as some changes are incorrect or need to be cleaned. A) Merged the stddef.h fix for older VS (tested on VS2008) B) Merged the VK_DOWN fix in both DirectX9 and DirectX11 fix C) Pragma to link on Windows examples, What exactly are you fixing? Could you describe the problem and the situation? I can't merge as is because it's full of commented bits which are messy and suggest the change isn't well understood. D) For list box we need to test the widget focus - however ListBox doesn't have such concept at the moment (PS. g.ActiveId is the widget that you are actively clicking on in most cases). Because ListBox() is implemented using a child window we can just use IsWindowFocused(), but that leaves a few problems open:
|
|
C) Sorry for short description, pragma's just to check compilator version and include appropriate header (MSVC++ 2008 doesn't have stdint.h). D) Yeah, multiline selection would be really great, I'm just started looking into your implementation and don't know much about it yet, but almost all other IMGUI libraries that I saw make last added widget active by default. |
|
C) But for the DirectX librairies what are you making those changes? D) I don't understand what you mean by "Last added widget active by default", it doesn't make sense per the definition of Active in ImGui. The "Active" widget is the widget the user has selected or is using. |
|
C) Sorry, I just used to link libraries with headers, but that's my changes, you can dismiss it, the fix was just for keys. D) I mean active in the terms of tab order (just take a look on imgui tutorials/libs) and when user selects it directly too, of course. |
|
D) It doesn't take TAB focus at all yet. It's easy to add but we'd need a way to visualize keyboard focus more generally in imgui (currently it is only used by text input and widgets which can transform into text input). |
|
I am closing this but added a separate todo entry in imgui.cpp to handle keyboard properly. |
Includes my merged PRs and everything in my dev branch. Haven't tested with it yet. Changelog: Test case for clip rect HACK: more recent Windows SDK and VS2017; disable graph Set size to amount of space required Merge pull request ocornut#349 from maksw2/master Merge pull request ocornut#347 from mgerhardy/341 Merge pull request ocornut#348 from mgerhardy/fixed-warning Merge pull request ocornut#346 from mgerhardy/280 Merge pull request ocornut#345 from mgerhardy/322 Merge pull request ocornut#344 from rherilier/fix-gcc-warnings Merge pull request ocornut#336 from rherilier/add-isusingviewmanipulate Merge pull request ocornut#335 from RedSkittleFox/alternative_window Merge pull request ocornut#334 from ocornut/fix-beginchildframe dear imgui update and small fixes Merge pull request ocornut#316 from Batres3/2DSupport Merge pull request ocornut#326 from Sayama3/use-push-pop-id Merge pull request ocornut#328 from georgeto/master Merge pull request ocornut#330 from maritim/master Merge pull request ocornut#331 from GiovanyH/patch-1 Merge pull request ocornut#318 from dougbinks/imgui_math_operators Merge pull request ocornut#312 from kimidaisuki22/master div 0 fixed Merge pull request ocornut#301 from ZingBallyhoo/using-any Merge pull request ocornut#300 from Clog41200/Configurable-limits Merge pull request ocornut#298 from xDUDSSx/fix/rotation_circles Merge pull request ocornut#297 from xDUDSSx/fix/vertical-aspect-scaling Merge pull request ocornut#289 from ComputationalBiomechanicsLab/fix_isusing-ignores-setid Merge pull request ocornut#291 from ocornut/fix_math_operators_include Merge pull request ocornut#282 from MohitSethi99/master Merge pull request ocornut#276 from pthom/virtual_destructors Merge pull request ocornut#271 from idbrii/clip-parent Merge pull request ocornut#270 from idbrii/btn-behaviour Merge pull request ocornut#265 from mgerhardy/pr/fix-minor-formatting Merge pull request ocornut#264 from mgerhardy/pr/div0 Merge pull request ocornut#269 from peter1745/hatched-line-thickness-enhancement Merge pull request ocornut#259 from miyanyan/master Merge branch 'master' of https://github.com/CedricGuillemet/ImGuizmo update dear imgui Merge pull request ocornut#256 from Aidiakapi/patch-1 Merge pull request ocornut#252 from aaronkirkham/master Merge pull request ocornut#249 from rokups/rk/mouse-capture Merge pull request ocornut#246 from mgerhardy/pr/viewmanipulate removed commented code fix click view cube Merge pull request ocornut#231 from mgerhardy/master Merge pull request ocornut#230 from mgerhardy/master Merge pull request ocornut#228 from longod/master Merge pull request ocornut#227 from madeso/master AddBezierCubic Merge pull request ocornut#226 from sherief/master revert culling test commit Merge pull request ocornut#203 from rokups/rk/misc-fixes Merge pull request ocornut#212 from zhaijialong/fix-behind-camera-cull Merge pull request ocornut#209 from VictorFouquet/fix_normalize scale is always local Merge pull request ocornut#202 from pezy/master imguizmo namespace Merge pull request ocornut#194 from JonathanHiggs/vcpkg-example 1.84 WIP Merge pull request ocornut#197 from idbrii/seq-btn-color Merge pull request ocornut#196 from idbrii/seq-big-handles
No description provided.