Fix misleading "unknown endpoint" errors on stealth operations#2
Open
0xAJPanda wants to merge 1 commit intooctra-labs:mainfrom
Open
Fix misleading "unknown endpoint" errors on stealth operations#20xAJPanda wants to merge 1 commit intooctra-labs:mainfrom
0xAJPanda wants to merge 1 commit intooctra-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team! Been testing the webcli on devnet (love what you're building btw) and ran into something that had me chasing my tail for a while.
When stealth send hits an error — like the recipient not having a registered view pubkey — the response comes back as
"unknown endpoint: POST /api/stealth/send"instead of the actual error. The route exists and works fine, but the error handler at line 291 catches any API response with an empty body and slaps "unknown endpoint" on it, even when it's a 500 from a real route.Took me a while to figure out the actual errors were hiding in the
EXCEPTION_WHATresponse header, which most people probably wouldn't think to check.What this changes:
EXCEPTION_WHATwhen availableSo instead of:
{"error": "unknown endpoint: POST /api/stealth/send"}You'd get:
{"error": "internal error on: POST /api/stealth/send (status 500)", "detail": "type must be string, but is null"}Small change (10 lines), shouldn't break anything. Happy to adjust if you'd prefer a different format for the error response.
Keep up the great work on the webcli — the encrypt/decrypt flow works really well.