Skip to content

Conversation

@MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Jan 2, 2023

The only problem with this PR is that warning and errors messages from Logs will be printed in stderr and disrupt the interface; but perhaps that should serve as an incentive to fix the original problem?

This also supersedes #20.

@tmcgilchrist
Copy link
Member

tmcgilchrist commented Jan 4, 2023

Build failure on ocaml-ci

4 |  (libraries unix capnp-rpc-lwt current_rpc ppx_deriving_yojson.runtime)
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Library "ppx_deriving_yojson.runtime" not found.

And the submodule should point to your fixes in let-def/lwd#40.
Other than that the changes look good.

@MisterDA
Copy link
Contributor Author

MisterDA commented Jan 4, 2023

Thanks for the review, I've fixed the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants