Open
Conversation
Owner
|
Ok, it's up to you, senior OSGi engineer ;) Make all needed there. |
Owner
|
@CodingFabian Is it possible then to use the library as usual (maven dependency) ? |
Contributor
Author
|
yes, it does not change a thing. it is still a normal jar file as before, the only difference is that the plugin will generate the above manifest.mf automatically. one could do that by hand, be the generated ones are much better, especially when stuff changes they are updated automatically. |
Owner
|
Does the |
Contributor
Author
|
yes |
Contributor
Author
|
@odiszapc what is your concern merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the generated manifest to be OSGi compliant. declaring all imported and exported packages. No other changes in any of the compiled classes