Use a fixed locale for timestamp conversion#7
Merged
clarlars merged 1 commit intoodk-x:masterfrom Mar 31, 2018
Merged
Conversation
linl33
force-pushed
the
timestamp-locale
branch
3 times, most recently
from
15b3bc0 to
0d37649
Compare
linl33
force-pushed
the
timestamp-locale
branch
from
0d37649 to
a895c50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a locale is not specified,
SimpleDateFormatuses the system's default locale. This causes problem when the locale expresses time differently from how time is expressed in English.The problem was brought to attention when a user reported on the forum that Survey couldn't display datetime nor save changes when the system locale is set to Arabic.
This PR adds overloaded methods for
milliSecondsFromNanosandmilliSecondsFromNanosthat accept a locale. The 2 original methods (now marked Deprecated) maintain the original behavior for backwards compatibility.