Skip to content

Conversation

@afma-odoo
Copy link
Contributor

task-4499493

@robodoo
Copy link
Collaborator

robodoo commented Dec 15, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team December 15, 2025 10:39
@afma-odoo
Copy link
Contributor Author

Hi Ismail and @ygu-odoo ,
Thank you for your work on this Saudi-Arabia localization page!
I made some changes/suggestions. Please take a look at it and let me know if you have any questions or comments. Thanks!

  • Modules: All Saudi Arabia modules have been added.
  • Structure: I reviewed the document to simplify the structure and align it with our new guidelines and templates for LOC documentation pages. Some sections were moved and added as notes/important alert blocks.
  • Sandbox and simulation (line 272 & 273): It would be helpful to include more information about when to use one or the other. Could you provide it? 
  • Simulation & Production (313): I split this section into two to be as precise and complete as possible: one for simulation modeand one for production mode.
  • Re-onboard vs Onboard (298, 331 & 362): When I tested it (for the first time), the available option was "onboard". Is this okay?
  • Invoice testing step (306 & 339), I added a step because a blue banner appears when I test it. Is this okay? Is this option also available in production mode?
  • Invoice testing step (306 & 339), I added some information to make the instructions as precise as possible. Let me know if it's incorrect.
  • QR code verification (453): I think we should add some more information about this note. What do you think?

Thank you for your help! ☺️


* - Name
- Technical name
- Description

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we adapt the order of the modules to be:

  1. Accounting
  2. Accounting Reports
  3. E-invoicing
  4. E-invoicing (Simplified)
  5. Point of Sale
  6. Withholding Tax

Inspiration taken from Brazil (https://www.odoo.com/documentation/19.0/applications/finance/fiscal_localizations/brazil.html)

Withholding taxes
-----------------

There are two available methods for calculating :doc:`withholding tax

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the external link to the withholding tax as the methods used for calculation in the Saudi package is different than the standard.


.. note::
It is also necessary to fill out similar information for partner companies.
- :ref:`Sandbox <localizations/saudi-arabia/sandbox>`: common preconfigured testing environment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to:

Sandbox: Common pre-configured testing environment; use it out of the box to simulate how the integration works

Simulation (Pre-Production): user-specific testing environment; use it to simulate your unique integration

- Open the :guilabel:`Sales` journal.
- Under the ZATCA tab, click :icon:`fa-refresh` :guilabel:`Onboard`.
- In the :guilabel:`Enter the OTP` window, enter the 6-digit :guilabel:`OTP` retrieved from the
Fatoora Simulation Portal under the Production Environment. Then click :guilabel:`Confirm`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the :guilabel:Enter the OTP window, enter the 6-digit :guilabel:OTP retrieved from the
Fatoora Simulation Portal under the Production Environment. Then click :guilabel:Confirm.

This line needs to be changed to:

In the :guilabel:Enter the OTP window, enter the 6-digit :guilabel:OTP retrieved from the
Fatoora Portal under the Production Environment. Then click :guilabel:Confirm.


.. note::
The same serial number can be used for all of the company's sales journals.
- :guilabel:`Simulation (Pre-Production)` mode invoices are not legally valid.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this note to be under line 345 (Under the simulation section)

The color of the message displayed in the chatter after an invoice is confirmed and submitted
indicates the following information:

- Green: invoice successfully accepted - The invoice is fully compliant and has been successfully

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to color code the warnings such as "Green" would be in the color green? same applies for Yellow and red.

- Open the :guilabel:`Sales` journal.
- Under the ZATCA tab, click :icon:`fa-refresh` :guilabel:`Onboard`.
- In the :guilabel:`Enter the OTP` window, enter the 6-digit :guilabel:`OTP` retrieved from the
Fatoora Simulation Portal under the Production Environment. Then click :guilabel:`Confirm`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add another point here similar to point 4 (line 335):

Invoice Synchronization:

Create and confirm customer invoices.

Once the invoice is confirmed, a blue banner appears; click Process now.

Ensure the response from the API is Action Successful. If not, review the API response displayed in the chatter and take the appropriate actions.

To verify the QR Code on the invoice, scan it using the official `ZATCA app
<https://zatca.gov.sa/en/AboutUs/ZATCAApps/Pages/default.aspx>`_.

.. note::

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing else to add regarding the QR code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants