Skip to content

Conversation

@theRealThagomizer
Copy link
Contributor

@theRealThagomizer theRealThagomizer commented Dec 23, 2025

Hi, @meval1006! Got a pretty quick update to the new-ish Optional Products page. There's a new section about adding an optional products section into quotations. Not too much to say about it beyond that. Thanks for reviewing!

This 19.0 PR can be FWP up to master.

@robodoo
Copy link
Collaborator

robodoo commented Dec 23, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team December 23, 2025 23:39
Copy link
Contributor

@meval1006 meval1006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theRealThagomizer , left some minor edits and a suggestion rewrite. Good job.

@theRealThagomizer theRealThagomizer force-pushed the 19.0-sales-optional-products-correction-thjud branch from 410f60b to 0746fc1 Compare December 24, 2025 00:47
@theRealThagomizer
Copy link
Contributor Author

@Felicious Shoot, I forgot to tag you in this. This is ready for your review!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like Ethan, the SME, approved this already so we can merge soon, after you address the super long line

@robodoo delegate=theRealThagomizer

Co-authored-by: meval1006 <meval@odoo.com>
Co-authored-by: Felicia Kuan <feku@odoo.com>
@theRealThagomizer theRealThagomizer force-pushed the 19.0-sales-optional-products-correction-thjud branch from 0746fc1 to 932ddf8 Compare December 30, 2025 19:52
@theRealThagomizer
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants