[ADD] estate: module with property model and corresponding views. (framework 101) #1082

farahdawod · 2025-12-18T16:33:13Z

/estate/init.py file imports all the models inside models related to estate

/estate/manifest.py file defines the name. version, category, sequence, summary, website link, dependencies, related data (views and access right files) of the "Estate" application.

/estate/models/estate_property.py creates the table "estate.property" with all its attributes:

name: fields.Char is the title of the posted property
type: fields.Selection is the type of the posted property (office, apartment, house, studio)
postcode: fields.Char is the postcode where the property is located
availability: fields.Date is the date from when the apartment is available
description: fields.Text is the description of the posted property
bedrooms: fields.Integer is the number of the bedrooms in the apartment
living_area: fields.Integer is the area (in sqm) of the apartment
currency_id: fields,Many2one imports the EUR currency
expected_price: fields.Monetary is the expected price of the posted apartment in euros
selling_price: fields.Monetary is the selling price of the posted apartment in euros
facades: fields.Integer is the number of facades in the posted apartment
garage: fields.Boolean indicates if there's a garage for the apartment
garden: fields.Boolean indicates if there's a garden for the apartment
garden_area: fields.Integer is the area (in sqm) of the apartment's garden
garden_orientation: fields.Selection is the orientation of the posted property's garden (north, south, east, west)
total_area: fields.Integer is the total area (in sqm) of the apartment
state: fields.Selection is the status of the posted property in regards to offers (new. offer_received, offer_accepted, sold, canceled)
active: fields.Boolean indicates if the posting of the property is still active

/estate/models/init.py file imports the estate_property.py table

/estate/models/security/ir.model.access.csv file defines the access rights of the estate_property model

/estate/models/views/estate_menus.xml: defines the top menu in the Estate application which views properties returned from the action estate_property_action

/estate/models/views/estate_property_views.xml:

defines the list view of the properties with the fields name, postcode, bedrooms, living_area, expected_price, selling_price and availability visible.
defines the form view of the properties as a sheet with the field name as the title. Visible underneath the title are the fields postcode, expected_price, selling_price and availability. Then the fields description, bedrooms, living_area, facades, garage, garden, garden_area, and garden orientation grouped in a notebook page.
defines an action estate_property_action which retrieves all the properties inside the estate.propety model in list or form views.
defines the search view of the properties where a user with the valid access rights can :
= search for a property using the fields name, postcode, expected_price, bedrooms. living_area, or facades
= filter the apartments based on the availability state (results will show the apartments where the 'state' field is 'new' or 'offer_received')
= group properties by postcode

robodoo · 2025-12-18T16:33:16Z

lost-odoo · 2025-12-19T08:58:57Z

Hello, could you please make one commit per chapter and also ensures that the runbot is green 😄
For your commits, you can follow these git guidelines: https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html

lost-odoo · 2025-12-19T13:08:44Z

For you pr message, you don't have to specify all the technical part. The title is what it is done and the message is "why". You should try to explain the functional part of the feature or fix, ...

So for instance, Adding a new module estate to better manage properties, ... You can add offers to a property as well as addings tags, ...

Something like this.

lost-odoo

I already made a small review.

Be careful with the final new lines, spacing and double quotes vs single quotes 😄

estate/__manifest__.py

estate/__init__.py

estate/__manifest__.py

lost-odoo · 2025-12-19T13:13:33Z

estate/__manifest__.py

+    'version': '1.0',
+    'category': 'Sales',
+    'sequence': 1,
+    'summary': 'Sell and bid on the hottest real estate properties.',


You could explain that in your pr message for instance

estate/__manifest__.py

estate/views/estate_property_views.xml

lost-odoo · 2025-12-19T13:22:19Z

estate/models/estate_property.py

+        selection =[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'),
+         ('sold', 'Sold'), ('canceled', 'Canceled')],


You can expand this into multiple lines.

estate/models/estate_property.py

…101)

lost-odoo · 2025-12-26T09:54:47Z

estate/__manifest__.py

+    'summary': 'Sell and bid on the hottest real estate properties.',
+    'website': 'https://www.odoo.com/app/estate',
+    'depends': [
+        'base_setup',


Shouldn't you use base here ?

lost-odoo · 2025-12-26T09:56:22Z

estate/models/estate_property.py

+    state = fields.Selection(
+        string="Status",
+        selection=[('new', "New"), ('offer_received', "Offer Received"), ('offer_accepted', "Offer Accepted"), ('sold', "Sold"), ('canceled', "Canceled")],
+        required=True,
+        copy=False,
+        default='new',
+    )


Don't split your fields definitions. You should move this up with the rest of them 😄

lost-odoo · 2025-12-26T09:57:22Z

estate/models/estate_property.py

+    active = fields.Boolean("Active", default=True)
+    buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False)
+    seller_id = fields.Many2one('res.users', string="Salesperson", default=lambda self: self.env.user)
+    tag_ids = fields.Many2many(
+        'estate.property.tag',
+        string="Tags",
+    )
+    offer_ids = fields.One2many(
+        'estate.property.offer',
+        'property_id',
+        string="Offers",
+    )
+    best_offer = fields.Monetary(
+        string="Best Offer",
+        compute='_compute_best_offer',
+    )


Here too, the format should be fields/constraints > create/write/unlink/compute/onchange > the rest.

lost-odoo · 2025-12-26T09:57:52Z

estate/models/estate_property.py

+    )
+
+    def sold_action(self):
+        for record in self:


Try to use a meaningful name instead of record -> property

lost-odoo · 2025-12-26T09:58:33Z

estate/models/estate_property.py

+            if record.state != 'canceled':
+                record.state = 'sold'
+            else:
+                raise UserError(record.env._("You can not sell a canceled property."))


FYI here you could use self.env._ but that's good also 😄

lost-odoo · 2025-12-26T10:25:13Z

estate/models/estate_property_offer.py

+    def create(self, vals_list):
+        for vals in vals_list:
+            if 'property_id' in vals and 'price' in vals:
+                linked_property = self.env['estate.property'].browse(vals['property_id'])


don't browse in a loop, try to do it outside the loop so it is more efficient otherwise you would have to query record one by one instead of all of them at once

lost-odoo · 2025-12-26T10:25:59Z

estate/models/estate_property_offer.py

+    @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            if 'property_id' in vals and 'price' in vals:


Shouldn't you make property_id and price required ?

lost-odoo · 2025-12-26T10:26:45Z

estate/models/estate_property_offer.py

+        for vals in vals_list:
+            if 'property_id' in vals and 'price' in vals:
+                linked_property = self.env['estate.property'].browse(vals['property_id'])
+                if linked_property.best_offer and vals['price'] < linked_property.best_offer:


Here too use the currency compare or float_compare 😄

lost-odoo · 2025-12-26T10:28:06Z

estate/models/estate_property_tag.py

+    )
+    _name_uniq = models.Constraint(
+        'unique(name)',
+        'This property tag already exists.',


Double quotes here 😄
Also don't forget about the splitting, try to put fields together

lost-odoo · 2025-12-26T10:30:09Z

ruff.toml

+# Exclude a variety of commonly ignored directories.
+exclude = [
+    ".bzr",
+    ".direnv",
+    ".eggs",
+    ".git",
+    ".git-rewrite",
+    ".hg",
+    ".ipynb_checkpoints",
+    ".mypy_cache",
+    ".nox",
+    ".pants.d",
+    ".pyenv",
+    ".pytest_cache",
+    ".pytype",
+    ".ruff_cache",
+    ".svn",
+    ".tox",
+    ".venv",
+    ".vscode",
+    "__pypackages__",
+    "_build",
+    "buck-out",
+    "build",
+    "dist",
+    "node_modules",
+    "site-packages",
+    "venv",
+]
+
+# Assume Python 3.12
+target-version = "py312"
+
+line-length = 255 
+[lint]
+# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default.
+select = ["ALL"]
+ignore = ["A","ARG","ANN","B","C901","D","DTZ","DOC","E501","ERA001","FBT","N","PD","PERF","PIE790","PLR","PT","Q","RSE102","RUF001","RUF012","S","SIM102","SIM108","SLF001","TID252","UP031","TRY003","TRY300","E713","SIM117","PGH003","RUF005","FIX","TD","TRY400","C408","PLW2901","PTH","EM102","INP001","CPY001","E266","PIE808","PLC2701","RUF100","FA100","FURB","C420","COM812","TRY002","B904","EM101","I001","UP006","UP007","RET","RUF021","E741","FAST","ASYNC","AIR","DJ","NPY","FA102","F401"]
+
+# Allow fix for all enabled rules (when `--fix`) is provided.
+fixable = ["ALL"]
+unfixable = ["A","ARG","ANN","B","C901","D","DTZ","DOC","E501","ERA001","FBT","N","PD","PERF","PIE790","PLR","PT","Q","RSE102","RUF001","RUF012","S","SIM102","SIM108","SLF001","TID252","UP031","TRY003","TRY300","E713","SIM117","PGH003","RUF005","FIX","TD","TRY400","C408","PLW2901","PTH","EM102","INP001","CPY001","E266","PIE808","PLC2701","RUF100","FA100","FURB","C420","COM812","TRY002","B904","EM101","I001","UP006","UP007","RET","RUF021","E741","FAST","ASYNC","AIR","DJ","NPY","FA102","F401"]
+[format]
+quote-style = "preserve"


Don't put your ruff file inside this commit it should only stays on your computer 😄

farahdawod changed the title ~~Created estate module with property model and corresponding views~~ [ADD] estate module with property model and corresponding views Dec 19, 2025

farahdawod changed the title ~~[ADD] estate module with property model and corresponding views~~ [ADD] estate: module with property model and corresponding views. (framework 101) Dec 19, 2025

lost-odoo requested changes Dec 19, 2025

View reviewed changes

farahdawod added 5 commits December 24, 2025 17:34

[ADD] Created estate module with property model and view

562c468

[ADD] estate_property_type: model and corresponding views (framework …

6266fba

…101)

[LINT] trying to pass runbot checks

dd84e7e

[ADD] created estate property offer and estate property tag models

c77fb19

[LINT] pass the check

e5a923c

farahdawod force-pushed the 19.0-tut-ahmfa branch from fa19da5 to e5a923c Compare December 24, 2025 16:36

lost-odoo requested changes Dec 26, 2025

View reviewed changes

		selection =[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'),
		('sold', 'Sold'), ('canceled', 'Canceled')],

[ADD] estate: module with property model and corresponding views. (framework 101) #1082

Are you sure you want to change the base?

[ADD] estate: module with property model and corresponding views. (framework 101) #1082

Uh oh!

Conversation

farahdawod commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Dec 18, 2025

Uh oh!

lost-odoo commented Dec 19, 2025

Uh oh!

lost-odoo commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lost-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

farahdawod commented Dec 18, 2025 •

edited

Loading

lost-odoo commented Dec 19, 2025 •

edited

Loading