[FIX] util/modules: fix correct latest version #372
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
sagu-odoo
force-pushed
the
master-fix-latest-version-sagu
branch
from
7d582ff to
ce6d28d
Compare
Contributor
Author
|
Hello @odoo/upgrade team, can i get review on this ?. Thanks in advance |
jjmaksoud
reviewed
Dec 23, 2025
src/util/modules.py
Outdated
Comment on lines
970
to
972
| def _caller_version(depth=None): | ||
| if depth is None: | ||
| depth = 3 if version_gte("16.0") else 2 |
Contributor
There was a problem hiding this comment.
Parsing the version is more costly than doing 1 more iteration
Suggested change
| def _caller_version(depth=None): | |
| if depth is None: | |
| depth = 3 if version_gte("16.0") else 2 | |
| def _caller_version(depth=2): |
Contributor
Author
There was a problem hiding this comment.
done. I thought it did on purpose.
sagu-odoo
force-pushed
the
master-fix-latest-version-sagu
branch
from
ce6d28d to
7aa1b58
Compare
Contributor
Author
|
upgradeci retry with base in all version |
during upgrade because of this in older version latest_version of module assign as modules because last third frame is for older_version is below for fixing this manage depth accordingly. for older version ``` (Pdb) frame.f_back <frame object at 0x5fbaf1938540> (Pdb) from inspect import Parameter, getsourcefile, signature *** ImportError: cannot import name Parameter (Pdb) from inspect import getsourcefile (Pdb) getsourcefile(frame.f_back) '/home/odoo/src/odoo/10.0/odoo/addons/base/maintenance/migrations/util/modules.py' (Pdb) getsourcefile(frame.f_back.f_back) '/home/odoo/src/odoo/10.0/odoo/addons/base/maintenance/migrations/base/9.saas~10.1.3/pre-20-crm_claim.py' (Pdb) getsourcefile(frame.f_back.f_back.f_back) '/home/odoo/src/odoo/10.0/odoo/modules/migration.py' ``` for above 16.0 version: ``` '/tmp/tmpu1jmod5o/migrations/util/modules.py' (Pdb) getsourcefile(frame.f_back.f_back) '/tmp/tmpu1jmod5o/migrations/util/modules.py' (Pdb) getsourcefile(frame.f_back.f_back.f_back) '/tmp/tmpu1jmod5o/migrations/base/saas~15.1.1.3/pre-10-modules.py' ``` before fix: ``` test_9_10.0=> select latest_version from ir_module_module where name='project_issue'; latest_version ---------------- modules (1 row) test_9_10.0=> ``` After fix: ``` test_9_10.0=> select latest_version from ir_module_module where name='project_issue'; latest_version ---------------- 10.0.1.0 (1 row) ```
sagu-odoo
force-pushed
the
master-fix-latest-version-sagu
branch
from
7aa1b58 to
aea049d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during upgrade because of this in older version
latest_versionof module assign asmodulesbecause last third frame is for older_version is below for fixing this manage depth accordingly.for older version
for above 16.0 version:
before fix:
After fix: