-
Notifications
You must be signed in to change notification settings - Fork 401
Implement counts record on Overview Tab. #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
tip: If you make your branch on this repo it's easier for the rest of us to clone without having to add your repo to remote :) |
|
General comments:
|
I think that 3 columns is bad
👍 |
|
Yeah, maybe another row under the summary section would be good |
|
Maybe we could shorten the last 20 games summary and put them both on one line? IMO having two additional rows on top is pushing down the "primary" content a little. Possibly using green/red for >50%/<50% might make it stand out a little more. The headers (SIDE/GAME MODE/etc.) could also maybe be styled for a little more visibility |
|
I wonder if it would make sense to put this section under the existing content, rather than over. |
|
replaced by #1635 |


fixes #771
Increased number of heroes in order to make the page alignment look cleaner.
Logic may not be the best, so definitely looking for some review/optimization. (had some difficulty understanding the transforms that were occurring to the data and why certain fields weren't accessible at certain stages in processing)
Container title probably deserves a better name, or at least it's own variable if we decide to change it in the future.