Skip to content

Conversation

@covertPZ
Copy link
Member

@covertPZ covertPZ commented Mar 11, 2017

fixes #771
Increased number of heroes in order to make the page alignment look cleaner.
Logic may not be the best, so definitely looking for some review/optimization. (had some difficulty understanding the transforms that were occurring to the data and why certain fields weren't accessible at certain stages in processing)
Container title probably deserves a better name, or at least it's own variable if we decide to change it in the future.

@covertPZ covertPZ requested review from blukai and howardchung March 11, 2017 00:33
@howardchung
Copy link
Member

tip: If you make your branch on this repo it's easier for the rest of us to clone without having to add your repo to remote :)

@howardchung
Copy link
Member

howardchung commented Mar 11, 2017

General comments:

  • Currently seems a bit buried (user has to scroll down a lot). Could we maybe move to a three column layout?
  • Probably should separate the sections (radiant/dire, patch, region, mode)
  • Context links to the matches filter page when number is clicked on (like heroes/players?) More generally this could be done for the rest of the counts
  • Instead of a table, maybe something a little more eye-catching? c3 has gauge charts: http://c3js.org/samples/chart_gauge.html or maybe donut charts: http://c3js.org/samples/chart_donut.html

@covertPZ
Copy link
Member Author

Ah, okay. I'll create the branches on the main repo from now on. Will make my workflow easier too :)

The three column layout makes things look super busy and will only get more filled if the counts get split into individual tables. This layout is also pushing it to show content without horizontal scrolling (below 1540px the counts would need to be pushed down)
image

Maybe we want to represent this data similar to the "Summary" section?

@blukai
Copy link
Member

blukai commented Mar 11, 2017

Currently seems a bit buried (user has to scroll down a lot). Could we maybe move to a three column layout?

I think that 3 columns is bad

👍

@howardchung
Copy link
Member

Yeah, maybe another row under the summary section would be good

@covertPZ
Copy link
Member Author

Still working out some parts of this, but before I go much further I'd like some feedback.
image

@howardchung
Copy link
Member

howardchung commented Mar 21, 2017

Maybe we could shorten the last 20 games summary and put them both on one line? IMO having two additional rows on top is pushing down the "primary" content a little.

Possibly using green/red for >50%/<50% might make it stand out a little more. The headers (SIDE/GAME MODE/etc.) could also maybe be styled for a little more visibility

@howardchung
Copy link
Member

I wonder if it would make sense to put this section under the existing content, rather than over.

@howardchung
Copy link
Member

replaced by #1635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

counts summary section on overview

3 participants