Reduce cookie banner delay to improve LCP#13
Open
jethroflanagan wants to merge 1 commit intomasterfrom
Open
Conversation
chama-ram
approved these changes
Apr 6, 2022
michael616kriel
approved these changes
Apr 6, 2022
Contributor
michael616kriel
left a comment
michael616kriel
left a comment
There was a problem hiding this comment.
It's just that one comment otherwise looks good
| ) | ||
|
|
||
| setTimeout(loadCookieBanner, 3000); | ||
| setTimeout(loadCookieBanner, 1); |
Contributor
There was a problem hiding this comment.
@jethroflanagan is not worth just removing the setTimeout if it's like only 1ms?
Contributor
Author
There was a problem hiding this comment.
@michael616kriel It should stay as it needs to be removed from the initial render loop, just as a performance thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Core Web Vitals LCP (largest contentful pain) score might be affected by the delayed paint of the cookie banner.
What: Reduced cookie banner timeout, but kept it there to delay it after other scripts