Conversation
|
|
||
| /** | ||
| * Used for testing. | ||
| */ |
There was a problem hiding this comment.
You may want to use annotation @VisibleForTesting instead of a comment.
|
As promised on the mailing list here is a few feedback about this PR. Regarding :
Given that this sqale approach was dropped in latest LTS I would not bother too much with it. Which brings me to the next point for maintainance of this plugin IMO : an effort should be made to upgrade this plugin to java 8 and the latest SQ LTS in order to drop deprecated APIs. (note this is unrelated to this PR directly but most probably required before releasing). HTH, and good luck with the maintainance of this plugin ! |
|
@tomverin Is this project still active? |
Hi!
Not sure if this is the proper way to submit a patch, but FWIW:
I spent some time trying to get the Android Lint plugin up to speed with version 25.1.2 of android-lint.
This is somewhat of a WIP, but would love some feedback before investing too much more time.
This should fix #17.
Some notes:
test-rules.xmlso they are not fragile when the realrules.xmlgets updated.export_reimport_should_end_up_with_same_quality_profileseemed to be failing even though it was reading in thetest-rules.xml. I must have missed something so I've disabled the test for now.its/plugin/projects, so it's probably broken.SonarRulesGenerator.javawhere it was not exporting the tags with the correct xml elementremediationFunctionandoffsetare used.In my quick testing, it seems to be working.
-Blake