Open
Conversation
As httpx strives for close compatibility with requests few changes needed to be made in curlify: * .lower() on headers (headers in http are case insensitive and httpx / requests use different cases. * httpx does not have a .body but contents can be accessed via .read() instead, curlify will now use either or. * httpx stores url in as URL object so we stringify it. Majority of the changes are in tests. * all tests are mocked out so there is no hitting of external services * payload tests are more relaxed. Testing for approximate existence of flags rather than exact string match. This is a workaround to deal with various discordant optional http headers.
IlyaSukhanov
force-pushed
the
httpx_support
branch
from
1c74dfa to
da9925c
Compare
|
I know this library has a long time since anything has been merged, but I would love to use this change! |
Owner
|
Hi! If you think that this change is still relevant please rebase it onto the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for httpx
As httpx strives for close compatibility with requests few
changes needed to be made in curlify
Majority of the changes are in tests.
Unrelated changes include a makefile to aide with testing and update of testing requirements.