Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325 and closes #338.
This PR refactors the handling of the snappable parcel layer back to the map viewer class, and fixes a couple of bugs in the meantime.
One issue remains where corners (and edge intersections) of the vector tiles get picked up and added as snappable vertices. This was an issue before, but with the new styles it becomes more obvious:
I've tried a few different hacks for filtering these out without success, so may need to remake the data with properties on each feature in order to really do the filtering properly. I have a ticket in the OpenLayers repo looking for help there as well.