Skip to content

Modify test to show it periodically failing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwalcock wants to merge 1 commit into
base: threadsafe-rebase
Choose a base branch
from
Open

Modify test to show it periodically failing #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/test-exec-dynamic.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,18 @@ BOOST_AUTO_TEST_CASE( param_after_node_2 ) {
}

BOOST_AUTO_TEST_CASE( multi_lstm ) {
vector<vector<float>> results(4);
const int threadCount = 8;

vector<vector<float>> results(threadCount);
dynet::ParameterCollection mod;
dynet::VanillaLSTMBuilder lstm_proto(2, 3, 10, mod);
dynet::LookupParameter lp_proto = mod.add_lookup_parameters(10, {3});
dynet::autobatch_flag = 0;

vector<thread> threads(4);
for (size_t t = 0; t < 4; ++t) {
vector<thread> threads(threadCount);
for (size_t t = 0; t < threadCount; ++t) {
threads[t] = thread([&, t]() {
cout << "Starting thread " << t << endl;
dynet::ComputationGraph cg;
dynet::VanillaLSTMBuilder lstm(lstm_proto);
dynet::LookupParameter lp(lp_proto);
Expand All @@ -135,11 +138,12 @@ BOOST_AUTO_TEST_CASE( multi_lstm ) {
losses.push_back(losses[0] + losses[2]);
Expression z = dynet::sum(losses);
results[t].push_back(as_scalar(z.value()));
cout << "Finishing thread " << t << endl;
});
}

for (size_t t = 0; t < 4; ++t) { threads[t].join(); }
for (size_t t = 0; t < 4; ++t) {
for (size_t t = 0; t < threadCount; ++t) { threads[t].join(); }
for (size_t t = 0; t < threadCount; ++t) {
for(size_t i = 1; i < results[t].size(); ++i) {
BOOST_CHECK_CLOSE(results[t][0], results[t][i], 0.0001);
}
Expand Down