feat: add ignore_warnings parameter to EditSource#36
Open
kts982 wants to merge 1 commit intooisee:mainfrom
Open
feat: add ignore_warnings parameter to EditSource#36kts982 wants to merge 1 commit intooisee:mainfrom
kts982 wants to merge 1 commit intooisee:mainfrom
Conversation
EditSource previously treated all syntax check results (errors, warnings, info) as fatal, blocking saves. This forced users to use syntax_check=false to work around pre-existing warnings like "Redundant conversion for type STRING", which feels unsafe. Now EditSource separates errors from warnings: - Errors (E) always block the save - Warnings (W) and info (I) block by default but can be allowed with ignore_warnings=true - Warnings are always returned in the response (syntaxWarnings field) Typical flow: Call 1: EditSource(...) → "2 warnings. Use ignore_warnings=true" Call 2: EditSource(..., ignore_warnings=true) → saves + activates Refs oisee#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E) from warnings (W) / info (I)ignore_warningsparameter (default:false— no breaking change)syntaxWarningsresponse fieldBehavior
ignore_warningsfalse(default)ignore_warnings=true)trueChanges
pkg/adt/workflows.go— filter syntax results by severity, addIgnoreWarningsoption, addSyntaxWarningsresult fieldinternal/mcp/handlers_fileio.go— parseignore_warningsparameterinternal/mcp/server.go— registerignore_warningsparameter on EditSource toolTest plan
go build ./pkg/adt/— compiles cleanlyTestListRecordingsfailures are pre-existing onmain)ignore_warnings=false(default): correctly blocked save with hint messageignore_warnings=true: saved, activated, warning returned insyntaxWarningsfieldRefs #33