feat: upgrade mcp-go to v0.43.2 with streamable HTTP transport#38
Open
danielheringers wants to merge 4 commits intooisee:mainfrom
Open
feat: upgrade mcp-go to v0.43.2 with streamable HTTP transport#38danielheringers wants to merge 4 commits intooisee:mainfrom
danielheringers wants to merge 4 commits intooisee:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/mark3labs/mcp-gofromv0.17.0tov0.43.2request.Params.Argumentstorequest.GetArguments()--transport http-streamable)stdioas the default transportChanges
go.mod,go.summcp-goand update transitive depsinternal/mcp/handlers_*.gorequest.GetArguments()internal/mcp/server.goServe,ServeStdio,ServeStreamableHTTP)cmd/vsp/main.go--transportflag andSAP_TRANSPORTenv supportstdio,http-streamable)internal/mcp/arguments_migration_test.gointernal/mcp/server_transport_test.gocmd/vsp/main_test.goREADME.md,ARCHITECTURE.md,CLAUDE.mdTest plan
go test -run TestHandlersUseGetArgumentsAPI ./internal/mcp -vgo test -run "TestServe_|TestServeStreamableHTTP_" ./internal/mcp -vgo test -run "TestValidateConfig_Transport|TestResolveConfig_Transport|TestRootCmdHasTransportFlag" ./cmd/vsp -vgo test ./internal/mcp ./cmd/vspgo test -cover ./internal/mcp ./cmd/vspinternal/mcp:9.1%cmd/vsp:15.1%/mcpinitialize: OKnotifications/initialized: OKtools/list: OK (non-empty list)Notes
go test ./...currently fails inpkg/cache(Example_withSQLite) due CGO/SQLite runtime constraint (CGO_ENABLED=0), which is outside this PR scope.GetDependencyZIPcompatibility behavior inembedded/deps/embed.goto avoid regressions while related upstream discussion is ongoing.Fixes #21