Skip to content

feat(components): add base for tab component#196

Merged
productdevbook merged 17 commits into
oku-ui:mainfrom
ejirocodes:feat/tab-component
Aug 13, 2023
Merged

feat(components): add base for tab component#196
productdevbook merged 17 commits into
oku-ui:mainfrom
ejirocodes:feat/tab-component

Conversation

@ejirocodes
Copy link
Copy Markdown
Contributor

@ejirocodes ejirocodes commented Jul 9, 2023

This is a WIP that addresses tabs component #23

@ejirocodes ejirocodes mentioned this pull request Jul 9, 2023
Closed
2 tasks
@dammy001 dammy001 force-pushed the feat/tab-component branch from 2228107 to 8815fa6 Compare July 10, 2023 14:05
@productdevbook
Copy link
Copy Markdown
Contributor

@ejirocodes sorry, @dammy001 accidentally posted a merge commit here

@productdevbook
Copy link
Copy Markdown
Contributor

What is the situation with this issue, if you want, I can support you.

@ejirocodes
Copy link
Copy Markdown
Contributor Author

@productdevbook, working on it tonight. Is there a discord channel I can reach you on?

@productdevbook
Copy link
Copy Markdown
Contributor

Yes, check website or this link discord

@oku-ui oku-ui deleted a comment from ejirocodes Jul 19, 2023
@oku-ui oku-ui deleted a comment from ejirocodes Jul 19, 2023
@productdevbook
Copy link
Copy Markdown
Contributor

https://discord.gg/dpUJmRmugD

@ejirocodes
Copy link
Copy Markdown
Contributor Author

discord.gg/dpUJmRmugD

@productdevbook, still not working man

@dammy001
Copy link
Copy Markdown
Contributor

@ejirocodes can you try this: https://discord.gg/9TFgjXvUcb

@ejirocodes ejirocodes force-pushed the feat/tab-component branch from 8815fa6 to 95acd89 Compare July 20, 2023 02:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 20, 2023

Thank you for following the naming conventions! 🙏

@ejirocodes
Copy link
Copy Markdown
Contributor Author

@productdevbook, this has been implemented. If you could please take a look and get the storybook to work properly. LMK if you have any questions.
Will write unit test for this component once it's finialised

@ejirocodes ejirocodes marked this pull request as ready for review July 20, 2023 02:47
@productdevbook productdevbook self-requested a review July 20, 2023 02:50
Comment thread packages/core/use-composable/src/index.ts
@dammy001
Copy link
Copy Markdown
Contributor

@productdevbook @ejirocodes Component file naming convention should follow camelCase and not kebab-case

@productdevbook
Copy link
Copy Markdown
Contributor

@productdevbook @ejirocodes Component file naming convention should follow camelCase and not kebab-case

Yes, but not now, the last. Before publishing. Please do not change file names at the moment. Because we can understand what is done.

@productdevbook
Copy link
Copy Markdown
Contributor

@ejirocodes Hi, useRef and more change, can you take a look at the new structure and other components and update your codes here?

@productdevbook
Copy link
Copy Markdown
Contributor

i'm working on it now

@productdevbook productdevbook self-assigned this Aug 3, 2023
@productdevbook productdevbook marked this pull request as draft August 3, 2023 09:09
@productdevbook productdevbook changed the title feat(wip): add base for tab component feat(components): add base for tab component Aug 13, 2023
@productdevbook productdevbook marked this pull request as ready for review August 13, 2023 15:55
@productdevbook productdevbook merged commit cebb6d1 into oku-ui:main Aug 13, 2023
@github-actions github-actions Bot mentioned this pull request Aug 13, 2023
@productdevbook
Copy link
Copy Markdown
Contributor

productdevbook commented Aug 13, 2023

@ejirocodes thank you, write unit test for this component you do this in the new pr. We will be waiting.

@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants