Skip to content

refactor(useEscapeKeydown): cleanup test#250

Merged
dammy001 merged 3 commits into
oku-ui:mainfrom
Cr0zy07:chore/EscapeKeydown-248
Jul 29, 2023
Merged

refactor(useEscapeKeydown): cleanup test#250
dammy001 merged 3 commits into
oku-ui:mainfrom
Cr0zy07:chore/EscapeKeydown-248

Conversation

@Cr0zy07
Copy link
Copy Markdown
Collaborator

@Cr0zy07 Cr0zy07 commented Jul 28, 2023

Description

remove duplicated code from useEscapeKeydown test

Linked Issues

refactor #248

Additional context

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 28, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook requested review from YeSuX and dammy001 July 28, 2023 08:52
Copy link
Copy Markdown
Contributor

@dammy001 dammy001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cr0zy07 can you also add a test to confirm that the event is not been called when a component unmount.

@Cr0zy07
Copy link
Copy Markdown
Collaborator Author

Cr0zy07 commented Jul 28, 2023

@dammy001, Okay, I will do it tonight...

@dammy001 dammy001 merged commit 73300be into oku-ui:main Jul 29, 2023
@github-actions github-actions Bot mentioned this pull request Jul 29, 2023
@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants