Skip to content

feat: use-rect package#274

Merged
dammy001 merged 6 commits into
mainfrom
unknown repository
Aug 10, 2023
Merged

feat: use-rect package#274
dammy001 merged 6 commits into
mainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 7, 2023

Description

Linked Issues

Additional context

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 7, 2023

Thank you for following the naming conventions! 🙏

@dammy001
Copy link
Copy Markdown
Contributor

dammy001 commented Aug 8, 2023

@ramzzo lock file is not up to date. Can you run pnpm i locally and push again

@productdevbook
Copy link
Copy Markdown
Contributor

packages/core/use-composable/src this code should be here. Let's not pack.

@dammy001
Copy link
Copy Markdown
Contributor

dammy001 commented Aug 8, 2023

packages/core/use-composable/src this code should be here. Let's not pack.

Yeah, true

Comment thread packages/components/use-rect/src/use-rect.ts Outdated
@productdevbook productdevbook linked an issue Aug 8, 2023 that may be closed by this pull request
@dammy001
Copy link
Copy Markdown
Contributor

dammy001 commented Aug 8, 2023

@ramzzo can you add minimal test for this?

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 8, 2023

Even though I downloaded the oku-ui utils package, I get the error that the oku-ui utils package does not exist. so I can't run the test and see the result. I tried deleting and re-downloading the node_modules and lock file but the situation was the same.

image

image

image

@productdevbook
Copy link
Copy Markdown
Contributor

productdevbook commented Aug 9, 2023

pnpm build:all after pnpm test

@dammy001 dammy001 merged commit 298b3ec into oku-ui:main Aug 10, 2023
@github-actions github-actions Bot mentioned this pull request Aug 10, 2023
@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use-rect package

2 participants