Skip to content

feat(collection): add stories#288

Merged
productdevbook merged 10 commits into
mainfrom
fix-collection
Aug 20, 2023
Merged

feat(collection): add stories#288
productdevbook merged 10 commits into
mainfrom
fix-collection

Conversation

@YeSuX
Copy link
Copy Markdown
Collaborator

@YeSuX YeSuX commented Aug 19, 2023

Description

Linked Issues

Additional context

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 19, 2023

Thank you for following the naming conventions! 🙏

Comment thread .storybook/style.css Outdated
@@ -1,4 +1,4 @@
@tailwind base;
/* @tailwind base; */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we do this ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

html default style can be reseted by taiwind base.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I delete the taiwind base

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will take a look at this

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 19, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.98% 3020 / 3639
🔵 Statements 82.98% 3020 / 3639
🔵 Functions 69.91% 86 / 123
🔵 Branches 80.99% 196 / 242
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/collection/src/collection.ts 99.35% 100% 100% 99.35% 111
Generated in workflow #617

Comment thread packages/components/collection/src/stories/CollectionDemo.vue Outdated
@productdevbook productdevbook marked this pull request as draft August 19, 2023 11:13
@productdevbook productdevbook marked this pull request as ready for review August 20, 2023 03:49
@productdevbook productdevbook changed the title feat(collection): add stories chore(collection): add stories Aug 20, 2023
@productdevbook productdevbook changed the title chore(collection): add stories feat(collection): add stories Aug 20, 2023
@productdevbook productdevbook merged commit 5e11edf into main Aug 20, 2023
@productdevbook productdevbook deleted the fix-collection branch August 20, 2023 03:56
@github-actions github-actions Bot mentioned this pull request Aug 20, 2023
@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants