Skip to content

refactor(toggle-group): migrate single and multiple groups to a single component#318

Merged
productdevbook merged 3 commits into
mainfrom
fix-toggle-group
Aug 31, 2023
Merged

refactor(toggle-group): migrate single and multiple groups to a single component#318
productdevbook merged 3 commits into
mainfrom
fix-toggle-group

Conversation

@productdevbook
Copy link
Copy Markdown
Contributor

Description

single and multiple in-kind components. That's why it's a one-component translation. This toolbar will make it easier to write and any errors there will be gone.

Linked Issues

Additional context

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 30, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title refactor: toggle group single and multiple to one component refactor(toggle-group): toggle group single and multiple to one component Aug 30, 2023
Comment thread packages/components/toggle-group/src/ToggleGroupItemImpl.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 30, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.18% 4727 / 5549
🔵 Statements 85.18% 4727 / 5549
🔵 Functions 69.46% 157 / 226
🔵 Branches 81.99% 346 / 422
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 80.33% 81.81% 14.28% 80.33% 83-84, 109-110, 112-113, 118-119, 134, 136, 139, 141-162, 165, 167
packages/components/toggle/src/toggle.ts 98.52% 85.71% 88.88% 98.52% 87, 90
Generated in workflow #713

@productdevbook productdevbook changed the title refactor(toggle-group): toggle group single and multiple to one component refactor(toggle-group): migrate single and multiple groups to a single component Aug 30, 2023
@productdevbook productdevbook merged commit 5286457 into main Aug 31, 2023
@productdevbook productdevbook deleted the fix-toggle-group branch August 31, 2023 09:31
@github-actions github-actions Bot mentioned this pull request Aug 31, 2023
@github-actions github-actions Bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant