Skip to content

feat(dialog): new component#338

Merged
productdevbook merged 35 commits into
mainfrom
feat-dialog
Sep 11, 2023
Merged

feat(dialog): new component#338
productdevbook merged 35 commits into
mainfrom
feat-dialog

Conversation

@kbrkiras
Copy link
Copy Markdown
Contributor

@kbrkiras kbrkiras commented Sep 6, 2023

Description

Linked Issues

close #9

Additional context

@kbrkiras kbrkiras self-assigned this Sep 6, 2023
@kbrkiras kbrkiras linked an issue Sep 6, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.09% 5103 / 5927
🔵 Statements 86.09% 5103 / 5927
🔵 Functions 72.83% 177 / 243
🔵 Branches 84.1% 402 / 478
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/provide/src/createProvide.ts 77.77% 75% 90.9% 77.77% 65-69, 103-127
Generated in workflow #858

@productdevbook
Copy link
Copy Markdown
Contributor

You best ❤️

@productdevbook productdevbook marked this pull request as ready for review September 11, 2023 11:22
Copy link
Copy Markdown
Contributor

@productdevbook productdevbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@productdevbook productdevbook merged commit d786d9d into main Sep 11, 2023
@productdevbook productdevbook deleted the feat-dialog branch September 11, 2023 12:06
This was referenced Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog

2 participants