Add IsFastStorageStrategy for more details when upgrade to FSS #2477
Merged
xiangjianmeng merged 14 commits intodevfrom Nov 10, 2022
Merged
Add IsFastStorageStrategy for more details when upgrade to FSS #2477xiangjianmeng merged 14 commits intodevfrom
xiangjianmeng merged 14 commits intodevfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2477 +/- ##
==========================================
- Coverage 35.79% 35.79% -0.01%
==========================================
Files 414 414
Lines 43547 43550 +3
==========================================
+ Hits 15587 15588 +1
- Misses 26844 26846 +2
Partials 1116 1116
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
giskook
force-pushed
the
zhangkai/fss-upgrade-tips
branch
2 times, most recently
from
8dbf6f3 to
c1a75a2
Compare
zjg555543
reviewed
Aug 31, 2022
lyh169
reviewed
Aug 31, 2022
giskook
force-pushed
the
zhangkai/fss-upgrade-tips
branch
4 times, most recently
from
dde9bfd to
1f350fb
Compare
zjg555543
reviewed
Sep 8, 2022
giskook
force-pushed
the
zhangkai/fss-upgrade-tips
branch
from
7480d7a to
5d277fe
Compare
add funcItem add IsUpgrade function export IsUpgradable from iavl module. add ut for IsUpgradeable, add IsUpgradeable support for repaire-state better tips and correct function name export iavl IsFastStorageStrategy function add tips with more details Add tips more details change ut's behavior when export IsFastStorageStrategy change default value when the function is changed to IsFastStorageStragety use constant instead of hard code, rename checkConflictOpts(opt) to tips fix NewDB function rm tips function rm hint field rename option to checkOption and put tips to conflictPairOption's field rename item's value to expect
giskook
force-pushed
the
zhangkai/fss-upgrade-tips
branch
from
5d277fe to
44e7e47
Compare
lyh169
previously approved these changes
Sep 9, 2022
zjg555543
previously approved these changes
Sep 13, 2022
zjg555543
approved these changes
Nov 3, 2022
lyh169
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add funcItem
add IsUpgrade function
export IsUpgradable from iavl module.
add ut for IsUpgradeable, add IsUpgradeable support for repaire-state
better tips and correct function name
export iavl IsFastStorageStrategy function
add tips with more details
Add tips more details
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: