Skip to content

node mode#2831

Merged
KamiD merged 4 commits intodevfrom
zjg/1952-node-mode
Dec 5, 2022
Merged

node mode#2831
KamiD merged 4 commits intodevfrom
zjg/1952-node-mode

Conversation

@zjg555543
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #2831 (3edb38e) into dev (f157f88) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #2831   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files         415      415           
  Lines       43813    43814    +1     
=======================================
+ Hits        15905    15907    +2     
  Misses      26752    26752           
+ Partials     1156     1155    -1     
Impacted Files Coverage Δ
app/node_mode.go 8.64% <0.00%> (-0.11%) ⬇️
app/utils/sanity/start.go 69.23% <ø> (ø)
x/wasm/keeper/keeper.go 80.69% <0.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

giskook
giskook previously approved these changes Dec 2, 2022
Copy link
Contributor

@giskook giskook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xzav3r
xzav3r previously approved these changes Dec 5, 2022
@zjg555543 zjg555543 dismissed stale reviews from xzav3r and giskook via 3edb38e December 5, 2022 03:03
@KamiD KamiD merged commit 754b423 into dev Dec 5, 2022
@KamiD KamiD deleted the zjg/1952-node-mode branch December 5, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants