Skip to content

fix(tools): check start block <= end block#116

Merged
louisliu2048 merged 2 commits intomainfrom
dumi/fix-573
Jan 23, 2026
Merged

fix(tools): check start block <= end block#116
louisliu2048 merged 2 commits intomainfrom
dumi/fix-573

Conversation

@dloghin
Copy link
Contributor

@dloghin dloghin commented Jan 23, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Other (please describe):

Code Guidelines

Before submitting your PR, please review the relevant code guidelines in the docs/ folder:

Specific Guidelines by Component:

Checklist

  • I have reviewed the relevant code guidelines in the docs/ folder
  • My code follows the coding standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Testing

Previously:

$ xlayer-reth-tools export --exported-data exp.rlp --start-block 10 --end-block 0
...
2026-01-23T08:38:26.351461Z  INFO Exporting blocks 10 to 0 (18446744073709551607 blocks total)
2026-01-23T08:38:26.351504Z  INFO Export complete! Exported 0 blocks to exp.rlp

After fix:

$ xlayer-reth-tools export --exported-data exp.rlp --start-block 10 --end-block 0
...
2026-01-23T08:41:30.923853Z  INFO Verifying storage consistency.
2026-01-23T08:41:30.924111Z ERROR Error: "Start block (10) is greater than end block (0)"

Additional Notes

@dloghin dloghin requested a review from Vui-Chee January 23, 2026 08:42
@louisliu2048 louisliu2048 merged commit 2980575 into main Jan 23, 2026
Vui-Chee added a commit that referenced this pull request Jan 30, 2026
* dev:
  fix: upgrade reth v1.10.2 version with bug fixes (#134)
  Update dependencies, use reth v1.10.2 and builder v0.3.0 (#133)
  chore: fix rust formatter (#132)
  chore: better rename, fix unused variable warning (#99) (#131)
  Fix comments (#127)
  Add trace log on tx cache hits (#126)
  replace magic error code number to INTERNAL_ERROR_CODE (#125)
  feat(legacy): remove eth_transactionPreExec (#124)
  fix tools readme (#123)
  fix(rpc): improve parameter validation in get_logs and service methods (#121)
  remove output file on error (#119)
  feat(legacy): support legacy routing for batch requests (#117)
  fix(legacy): avoid possible panic on malformed block params (#111)
  fallback to legacy if res is empty (#118)
  refactor(rpc): remove transaction_pre_exec API (#120)
  use XLayerPayloadServiceBuilder to simplify main() codes, merge to main branch (#112)
  fix(tools): check end block >= start block (#116)
  forward req to legacy on err (#110)
  fix: resolve audit issues related to flashblocks subscription (#113)
  fix(rpc): add trace_address for delegatecall and fix address format c… (#104)
@dloghin dloghin deleted the dumi/fix-573 branch February 11, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants