Is RubyUnits::Unit#unit_name still used?

[davidstosik]

Hello,

Commit 29c9466 deletes all lines that set @unit_name in RubyUnits::Unit, but attr_accessor :unit_name is still there.

Was this an omission?

Thanks,
David

[olbrich]

Probably. I'll look into it. Thanks.

[cromwellryan]

@unit_name is set in lines 315 and 263.

[davidstosik]

Being set does not mean it's ever used, and it does not seem to be. ;)

[cromwellryan]

Fair enough, but I was (in my head) referring to external usages.

[mathieujobin]

I was expecting

'34 mm'.to_unit.unit_name

to return mm but it did not, now I just found #units, that method will remain, correct?

[olbrich]

I have no plans to remove #units