Skip to content

Modifying core types should be optional #124

@kmcphillips

Description

@kmcphillips

This is a solid library. I can't find any unit tool in ruby that touches this one.

Unfortunately we can't bring it into our project because this gem opens up and modifies a number of core types: Array, Date, Fixnum, Math, Numeric, Object, String, Time

This is bad style and is dangerous. Is there a reason these core type modifications were made mandatory? They should be opt-in similar to how namespacing is done. These core extensions are depended on for internal implementation as well so I can't even selectively include units and conversions without modifying all those above classes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions