Skip to content

Fix currency parsing stack limit too deep error#107

Closed
ahacking wants to merge 1 commit intoolbrich:masterfrom
ahacking:fix_currency_parsing
Closed

Fix currency parsing stack limit too deep error#107
ahacking wants to merge 1 commit intoolbrich:masterfrom
ahacking:fix_currency_parsing

Conversation

@ahacking
Copy link

Attempting to parse Unit('$1.45') throws a 'stack limit reached' error.

  • Fixed parse_into_numbers_and_units to account for leading '$'
  • Added test for currency parsing

@ahacking ahacking force-pushed the fix_currency_parsing branch from e4830fa to 2b1c49a Compare August 21, 2014 15:05
@rposborne
Copy link
Contributor

+1

@rposborne
Copy link
Contributor

@olbrich any chance this will be addressed in the 2.0 release?

@olbrich
Copy link
Owner

olbrich commented Nov 19, 2015

@rposborne I'm in the process of completely rewriting the parsing engine. I did come across the problems with currency already and have it working. Also included is the ability to parse currency in formats like $1,000,000 and ($1,000) (for negative numbers).

@rposborne
Copy link
Contributor

@olbrich fantastic. You have done some great work with this gem!

@alecdotninja
Copy link

@olbrich I appreciate all of your work on this gem. Is there any update on when a new version may be published with a fix for this issue?

@olbrich
Copy link
Owner

olbrich commented Jan 14, 2023

This has been fixed for a while, I just neglected to close it.

@olbrich olbrich closed this Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants