Fix currency parsing stack limit too deep error#107
Closed
ahacking wants to merge 1 commit intoolbrich:masterfrom
Closed
Fix currency parsing stack limit too deep error#107ahacking wants to merge 1 commit intoolbrich:masterfrom
ahacking wants to merge 1 commit intoolbrich:masterfrom
Conversation
e4830fa to
2b1c49a
Compare
Contributor
|
+1 |
Contributor
|
@olbrich any chance this will be addressed in the 2.0 release? |
Owner
|
@rposborne I'm in the process of completely rewriting the parsing engine. I did come across the problems with currency already and have it working. Also included is the ability to parse currency in formats like |
Contributor
|
@olbrich fantastic. You have done some great work with this gem! |
|
@olbrich I appreciate all of your work on this gem. Is there any update on when a new version may be published with a fix for this issue? |
Owner
|
This has been fixed for a while, I just neglected to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to parse Unit('$1.45') throws a 'stack limit reached' error.