Skip to content

Faster ruby-units #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smathieu wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Faster ruby-units #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3b4745a
Plan
smathieu Mar 3, 2026
41cbfa8
Replace regex-based unit parsing with hash-based architecture
smathieu Mar 3, 2026
57f9f03
Fix scalar bug
smathieu Mar 3, 2026
7fe1279
Add C extension for hot path acceleration (Phases 2-4)
smathieu Mar 3, 2026
498db62
Fix Unit.new(nil, "unit") raising ArgumentError instead of defaulting…
smathieu Mar 3, 2026
15797cb
Fix Unit.new(numeric, Unit) and multi-word unit alias parsing
smathieu Mar 3, 2026
a9d7beb
Optimize C extension: replace rb_funcall with direct ivar/hash access
smathieu Mar 4, 2026
e8af017
Harden C extension and clean up review findings
smathieu Mar 4, 2026
48d91d7
Remove .claude/settings.local.json from tracking and gitignore it
smathieu Mar 4, 2026
137527e
Add rake-compiler to Gemfile for C extension build
smathieu Mar 4, 2026
0461eed
Remove plan files and gitignore C extension build artifacts
smathieu Mar 4, 2026
6c8958a
Skip C extension compilation on JRuby
smathieu Mar 4, 2026
f5de161
Fix temperature base_scalar when parsed from cache
smathieu Mar 4, 2026
5924de0
Merge pull request #1 from tangibleMaterials/c-implementation
smathieu Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,10 @@
/vendor/bundle/
# rspec failure tracking
.rspec_status
.claude/settings.local.json

# C extension build artifacts
ext/ruby_units/*.o
ext/ruby_units/*.so
ext/ruby_units/Makefile
lib/ruby_units/*.so
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ end

gem "bigdecimal"
gem "rake"
gem "rake-compiler"
gem "rspec", "~> 3.0"
gem "simplecov"
gem "yard"
Expand Down
18 changes: 15 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ GEM
zeitwerk (~> 2.6)
erb (6.0.1)
erb (6.0.1-java)
ffi (1.17.2)
ffi (1.17.2-arm64-darwin)
ffi (1.17.2-java)
ffi (1.17.2-x86_64-linux-gnu)
Expand Down Expand Up @@ -96,7 +97,11 @@ GEM
logger (1.7.0)
lumberjack (1.4.2)
method_source (1.1.0)
mini_portile2 (2.8.9)
nenv (0.3.0)
nokogiri (1.18.10)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.18.10-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.10-java)
Expand All @@ -107,6 +112,7 @@ GEM
nenv (~> 0.1)
shellany (~> 0.0)
observer (0.1.2)
open3 (0.2.1)
ostruct (0.6.3)
parallel (1.27.0)
parser (3.3.10.0)
Expand All @@ -133,6 +139,8 @@ GEM
racc (1.8.1-java)
rainbow (3.1.1)
rake (13.3.1)
rake-compiler (1.3.1)
rake
rb-fsevent (0.11.2)
rb-inotify (0.11.1)
ffi (~> 1.0)
Expand Down Expand Up @@ -205,16 +213,18 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
solargraph (0.57.0)
solargraph (0.58.2)
ast (~> 2.4.3)
backport (~> 1.2)
benchmark (~> 0.4)
bundler (~> 2.0)
bundler (>= 2.0)
diff-lcs (~> 1.4)
jaro_winkler (~> 1.6, >= 1.6.1)
kramdown (~> 2.3)
kramdown-parser-gfm (~> 1.1)
logger (~> 1.6)
observer (~> 0.1)
open3 (~> 0.2.1)
ostruct (~> 0.6)
parser (~> 3.0)
prism (~> 1.4)
Expand Down Expand Up @@ -246,6 +256,7 @@ GEM
zeitwerk (2.7.4)

PLATFORMS
aarch64-linux
arm64-darwin-25
java
universal-java-11
Expand All @@ -259,6 +270,7 @@ DEPENDENCIES
guard-rspec
pry
rake
rake-compiler
redcarpet
reek
rspec (~> 3.0)
Expand All @@ -278,4 +290,4 @@ DEPENDENCIES
yard

BUNDLED WITH
2.7.2
4.0.3
11 changes: 11 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,15 @@ require "rspec/core/rake_task"

RSpec::Core::RakeTask.new(:spec)

unless RUBY_ENGINE == "jruby"
require "rake/extensiontask"

Rake::ExtensionTask.new("ruby_units_ext") do |ext|
ext.lib_dir = "lib/ruby_units"
ext.ext_dir = "ext/ruby_units"
end

task spec: :compile
end

task default: :spec
5 changes: 5 additions & 0 deletions ext/ruby_units/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# frozen_string_literal: true

require "mkmf"

create_makefile("ruby_units/ruby_units_ext")
Loading