Fix failing case of subtraction losing Units class#61
Merged
olbrich merged 2 commits intoolbrich:masterfrom Jan 25, 2013
Merged
Fix failing case of subtraction losing Units class#61olbrich merged 2 commits intoolbrich:masterfrom
olbrich merged 2 commits intoolbrich:masterfrom
Conversation
Currently, if you subtract a zero unit from another, it will revert to the scalar class, rather than maintain its Unit class. However for addition, it is still respected.
This fix caters for the loss of Units class when two zero Units are subtracted.
olbrich
added a commit
that referenced
this pull request
Jan 25, 2013
Fix failing case of subtraction losing Units class
Owner
|
Thanks! |
Contributor
Author
|
No, thank you! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you subtract 2 Units that are zero, the result is not a Unit, but the scalar object. However if you add them, it respects the Units class correctly.
Here is the fix and 2 tests that prove it.