Support passing Time objects to Time.at#70
Merged
olbrich merged 1 commit intoolbrich:masterfrom Jun 12, 2013
agraves:fix_time_at
Merged
Support passing Time objects to Time.at#70olbrich merged 1 commit intoolbrich:masterfrom agraves:fix_time_at
olbrich merged 1 commit intoolbrich:masterfrom
agraves:fix_time_at
Conversation
Contributor
Author
|
There's a YAML error, but that was present on master before I started. |
Contributor
Author
|
Rebased vs master with my other fixes, and the suite is now passing on Travis. |
Contributor
Author
|
@olbrich Any chance we can get this merged? This bug is killing us in production -- it's forcing us to run a fork and my impetus for fixing the other bugs... |
Owner
|
I'll see if I can take a look at it tonight. /dev/iphone/kolbrich On Jun 11, 2013, at 11:27 AM, Aaron Graves notifications@github.com wrote:
|
olbrich
added a commit
that referenced
this pull request
Jun 12, 2013
Support passing Time objects to Time.at
|
👍 |
Contributor
Author
|
Thanks @olbrich! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented @jasonhutchens's fix with tests.