Add a handler that generate fake news related to #thefoobar#138
Draft
Christopher-Chianelli wants to merge 2 commits intooldterns:masterfrom
Draft
Add a handler that generate fake news related to #thefoobar#138Christopher-Chianelli wants to merge 2 commits intooldterns:masterfrom
Christopher-Chianelli wants to merge 2 commits intooldterns:masterfrom
Conversation
cuijulian
requested changes
Jul 2, 2019
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Perhaps keep license consistent with rest of the project? Though both Apache and MIT are both permissive, so this might just be nitpicking.
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
salmanfs815
reviewed
Jul 4, 2019
vilebot/src/main/java/com/oldterns/vilebot/handlers/user/FoobarNews.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Salman Siddiqui <salmanf.siddiqui@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress and require feedback for further work. In particular:
I have set a very high limit for testing purposes; I will change the limit to a more sane value once the PR is ready to be merged.
Current features:
Tests will be added once the features are more nailed down.
TODO: