Open
Conversation
Christopher-Chianelli
force-pushed
the
reddit-rss
branch
from
f74707b to
620c29d
Compare
amisevsk
reviewed
Sep 24, 2019
| Configuration botConfiguration = | ||
| new Configuration.Builder().setName( ircNick ).setLogin( ircUser ).setRealName( ircRealName ).addServer( ircServerAddress, | ||
| ircPort ).addAutoJoinChannel( ircChannel ).setAutoReconnect( true ).addListener( new Vilebot() ).addListener( new AdminManagement() ).addListener( new AdminPing() ).addListener( new Auth() ).addListener( new GetLog() ).addListener( new com.oldterns.vilebot.handlers.admin.Help() ).addListener( new NickChange() ).addListener( new com.oldterns.vilebot.handlers.admin.Ops() ).addListener( new Quit() ).addListener( new AnswerQuestion() ).addListener( new Ascii() ).addListener( new ChatLogger() ).addListener( new Church() ).addListener( new Countdown() ).addListener( new Decide() ).addListener( new Excuses() ).addListener( new FakeNews() ).addListener( new Fortune() ).addListener( new GetInfoOn() ).addListener( new Help() ).addListener( new ImageToAscii() ).addListener( new Inspiration() ).addListener( new Jaziz() ).addListener( new Jokes() ).addListener( new Kaomoji() ).addListener( new Karma() ).addListener( new KarmaRoll() ).addListener( new LastMessageSed() ).addListener( new LastSeen() ).addListener( new Markov() ).addListener( new News() ).addListener( new Omgword() ).addListener( new Ops() ).addListener( new QuotesAndFacts() ).addListener( new RemindMe() ).addListener( new RockPaperScissors() ).addListener( new Trivia() ).addListener( new Ttc() ).addListener( new TwitterCorrection() ).addListener( new UrlTitleAnnouncer() ).addListener( new UrlTweetAnnouncer() ).addListener( new Userlists() ).addListener( new UserPing() ).addListener( new Weather() ).buildConfiguration(); | ||
| ircPort ).addAutoJoinChannel( ircChannel ).setAutoReconnect( true ).addListener( new Vilebot() ).addListener( new AdminManagement() ).addListener( new AdminPing() ).addListener( new Auth() ).addListener( new GetLog() ).addListener( new com.oldterns.vilebot.handlers.admin.Help() ).addListener( new NickChange() ).addListener( new com.oldterns.vilebot.handlers.admin.Ops() ).addListener( new Quit() ).addListener( new AnswerQuestion() ).addListener( new Ascii() ).addListener( new ChatLogger() ).addListener( new Church() ).addListener( new Countdown() ).addListener( new Decide() ).addListener( new Excuses() ).addListener( new FakeNews() ).addListener( new Fortune() ).addListener( new GetInfoOn() ).addListener( new Help() ).addListener( new ImageToAscii() ).addListener( new Inspiration() ).addListener( new Jaziz() ).addListener( new Jokes() ).addListener( new Kaomoji() ).addListener( new Karma() ).addListener( new KarmaRoll() ).addListener( new LastMessageSed() ).addListener( new LastSeen() ).addListener( new Markov() ).addListener( new News() ).addListener( new Omgword() ).addListener( new Ops() ).addListener( new QuotesAndFacts() ).addListener( new Reddit() ).addListener( new RemindMe() ).addListener( new RockPaperScissors() ).addListener( new Trivia() ).addListener( new Ttc() ).addListener( new TwitterCorrection() ).addListener( new UrlTitleAnnouncer() ).addListener( new UrlTweetAnnouncer() ).addListener( new Userlists() ).addListener( new UserPing() ).addListener( new Weather() ).buildConfiguration(); |
There was a problem hiding this comment.
Y'all, what is this line? Ends on column 1645?? At the very least break it up a little:
Configuration botConfiguration =
new Configuration.Builder()
.setName( ircNick )
.setLogin( ircUser )
.setRealName( ircRealName )
.addServer( ircServerAddress, ircPort )
.addAutoJoinChannel( ircChannel )
.setAutoReconnect( true )
.addListener( new Vilebot() )
.addListener( new AdminManagement() )
.addListener( new AdminPing() )
.addListener( new Auth() )
.addListener( new GetLog() )
.addListener( new com.oldterns.vilebot.handlers.admin.Help() )
.addListener( new NickChange() )
.addListener( new com.oldterns.vilebot.handlers.admin.Ops() )
.addListener( new Quit() )
.addListener( new AnswerQuestion() )
.addListener( new Ascii() )
.addListener( new ChatLogger() )
.addListener( new Church() )
.addListener( new Countdown() )
.addListener( new Decide() )
.addListener( new Excuses() )
.addListener( new FakeNews() )
.addListener( new Fortune() )
.addListener( new GetInfoOn() )
.addListener( new Help() )
.addListener( new ImageToAscii() )
.addListener( new Inspiration() )
.addListener( new Jaziz() )
.addListener( new Jokes() )
.addListener( new Kaomoji() )
.addListener( new Karma() )
.addListener( new KarmaRoll() )
.addListener( new LastMessageSed() )
.addListener( new LastSeen() )
.addListener( new Markov() )
.addListener( new News() )
.addListener( new Omgword() )
.addListener( new Ops() )
.addListener( new QuotesAndFacts() )
.addListener( new Reddit() )
.addListener( new RemindMe() )
.addListener( new RockPaperScissors() )
.addListener( new Trivia() )
.addListener( new Ttc() )
.addListener( new TwitterCorrection() )
.addListener( new UrlTitleAnnouncer() )
.addListener( new UrlTweetAnnouncer() )
.addListener( new Userlists() )
.addListener( new UserPing() )
.addListener( new Weather() )
.buildConfiguration();
Contributor
Author
There was a problem hiding this comment.
The VIleBot1 formatter does that. However, this task should be done in a more generic way.
There was a problem hiding this comment.
I thought it was a running joke tbh, which is why I never bothered to reformat it.
Contributor
Author
There was a problem hiding this comment.
Running jokes have no place in code, not even in joke code
There was a problem hiding this comment.
Then the formatter is busted. Alternatively,
Builder builder = new Configuration.Builder();
builder.setName( ircNick );
builder.setLogin( ircUser )
// [...]
cuijulian
reviewed
Sep 24, 2019
| private Map<String, Integer> dumpSize = new HashMap<>(); | ||
|
|
||
| private static final String PASTEBIN_API_URL = Vilebot.getConfig().get("pastebinApiUrl"); | ||
| private static final String PASTEBIN_API_URL = Vilebot.getConfig().get( "pastebinApiUrl" ); |
There was a problem hiding this comment.
+1 for fixing this formatting, never got around to doing it.
Contributor
Author
There was a problem hiding this comment.
mvn did it for me; if you run mvn clean install it will auto-format your code
cuijulian
requested changes
Sep 24, 2019
cuijulian
left a comment
cuijulian
left a comment
There was a problem hiding this comment.
Some good fixes in this PR, +1! Please add some unit tests as well. Refer to NewsTest.java for examples. Other than that looks good!
| import java.util.List; | ||
| import java.util.regex.Matcher; | ||
|
|
||
| public abstract class NewsParser |
There was a problem hiding this comment.
Now that this class is used for something other than news parsing, maybe rename it to something more generic like FeedParser? Not a blocker, just a recommendation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.