Open
Conversation
Closes oldterns#165 Signed-off-by: David Thompson <davthomp@redhat.com>
Contributor
Author
|
@Kevin-Mok pipeline appears to be working (see https://github.com/datho7561/VileBot/actions?query=branch%3A165-github-actions), but there is a test failure. Do you think I should look into fixing that failure in this PR? |
|
@datho7561 We can open a new issue for it. Do you know if this will run the tests for @Christopher-Chianelli's #161 PR? |
Contributor
|
Reading it, as of now, no; but I know what modifications to make to make it work on my PR |
Contributor
|
In regards to the test failure, it appears to be a BOM (Byte Order Mark) issue that present in the news feed RSS (It also why !news isn't working; it was introduced one day and was never removed). These are bad tests; they depend on the internet; I have a solution for test of these services in my PR. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
Signed-off-by: David Thompson davthomp@redhat.com