Skip to content

chore: pin poetry version==1.8.5#409

Merged
ParthSareen merged 2 commits intoparth/image-type-generatefrom
parth/pin-poetry-version
Jan 7, 2025
Merged

chore: pin poetry version==1.8.5#409
ParthSareen merged 2 commits intoparth/image-type-generatefrom
parth/pin-poetry-version

Conversation

@ParthSareen
Copy link
Copy Markdown
Member

@ParthSareen ParthSareen commented Jan 6, 2025

Test runner currently installs poetry 2.0.0 which introduces many breaking changes
Tracking in #410

image

@ParthSareen ParthSareen requested a review from mxyng January 6, 2025 19:19
@mxyng
Copy link
Copy Markdown
Collaborator

mxyng commented Jan 6, 2025

Instead of pinning, the project should be updated to be compatible with 2.0. It brings in positive changes with the breaking changes being fairly minor

@ParthSareen
Copy link
Copy Markdown
Member Author

ParthSareen commented Jan 6, 2025

@mxyng cool if that's a follow up? Want to get #408 and #398 in first. Blocked on this right now

@ParthSareen ParthSareen changed the title pin poetry version==1.8.5 chore: pin poetry version==1.8.5 Jan 7, 2025
@ParthSareen ParthSareen merged commit 34dc5df into parth/image-type-generate Jan 7, 2025
@ParthSareen ParthSareen deleted the parth/pin-poetry-version branch January 7, 2025 01:58
ParthSareen added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants