Update of tools.py to nicely manage numbers instead of concat strings#443
Merged
ParthSareen merged 3 commits intoollama:mainfrom Feb 14, 2025
Merged
Update of tools.py to nicely manage numbers instead of concat strings#443ParthSareen merged 3 commits intoollama:mainfrom
ParthSareen merged 3 commits intoollama:mainfrom
Conversation
Member
|
Didn't add this on purpose initially to show that LLM tool use doesn't always conform exactly to schema. Happy to add this if you can add a quick comment as to why the cast exists. Thanks! |
Contributor
Author
|
Sure thing. Pls check now the PR |
ParthSareen
reviewed
Feb 14, 2025
ParthSareen
reviewed
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix the prompt "What is 30 plus 12?" produces '3012'
With this fix the result is 42