Skip to content

Conversation

@rjmunro
Copy link

@rjmunro rjmunro commented Jun 19, 2013

A bunch of changes I needed to get this to work with my cordova-cli project, based on cordova 2.8.

@olore
Copy link
Owner

olore commented Jul 9, 2013

Thanks for posting this. I didn't see it until today, but will merge it in asap.

@shaks786
Copy link

any update

@rjmunro
Copy link
Author

rjmunro commented Jul 18, 2013

I'm still working on this in my fork - I need it for 2 different projects where I work. I'm struggling to figure out the best way to avoid the changes to AppDelegate. With cordova cli, which will ship with Cordova 3 starting tomorrow, AppDelegate can get regenerated back to it's original state, so requiring a manual change is a big no-no. See http://stackoverflow.com/q/17658160/3408 if you have any ideas.

@olore
Copy link
Owner

olore commented Jul 20, 2013

I haven't had a chance to try this out.
@rjmunro - it sounds like you are still working on this? Should I wait to merge or is this still good?

@rjmunro
Copy link
Author

rjmunro commented Jul 22, 2013

This is still good, but I am working on more.

Currently, Android isn't working for me - I get a notification, but when I select it, I am not returned to the app.

I also have a branch where I am working on avoiding changes to AppDelegate.m for iOS.

@Philzen
Copy link

Philzen commented Oct 2, 2013

stackoverflow.com/questions/13720071/cordova-local-notification-android-plugin-2-2-upgrade/

@rjmunro Had the same problem on android. A couple of solutions to this described in the above link - however the only one that worked for me so far was explicitely creating the intent using the actual internal name (like com.changeit.killerapp) of my app - which is suboptimal and i don't get why it isn't be able to grab that from the context when i tried like desribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants