Skip to content

[misc] add auth interfaces#104

Merged
slin1237 merged 1 commit into
mainfrom
multi-cloud-auth/interface
Jun 30, 2025
Merged

[misc] add auth interfaces#104
slin1237 merged 1 commit into
mainfrom
multi-cloud-auth/interface

Conversation

@slin1237
Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

this PR adds interface for multi cloud auth

Which issue(s) this PR fixes:

#94 #95 #96

Fixes #
#95 #96

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@github-actions github-actions Bot added bug Something isn't working cleanup design documentation Documentation changes feature labels Jun 30, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a flexible and extensible authentication framework to support multi-cloud environments. It defines the core interfaces and a default implementation for managing credentials across different providers like OCI, AWS, GCP, Azure, and GitHub. The framework also includes a chain provider for trying multiple authentication methods and an HTTP transport for automatically signing HTTP requests.

Highlights

  • Auth Interfaces: Introduces interfaces for multi-cloud authentication, including Provider, AuthType, Credentials, Config, and Factory.
  • Default Factory Implementation: Adds a DefaultFactory struct that implements the Factory interface, allowing registration and creation of credentials for different providers.
  • Provider Registration: Provides methods for registering provider factories with the DefaultFactory.
  • Credentials Creation: Implements the Create method in DefaultFactory to create credentials based on the provided configuration, including fallback mechanisms.
  • Supported Providers and Auth Types: Adds methods to retrieve supported providers and authentication types for each provider.
  • Chain Provider: Introduces a ChainProvider to try multiple credential providers in sequence until one succeeds.
  • HTTP Transport: Adds an HTTPTransport to wrap http.RoundTripper with authentication, signing requests with the appropriate auth headers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@slin1237
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces interfaces and a factory for multi-cloud authentication. The changes include new interfaces for providers and authentication types, a default factory implementation, and corresponding tests. The review identified potential race conditions in the global factory and the need for test isolation. Additionally, a suggestion was made to improve the structure of the fx module.

Comment thread pkg/auth/factory.go
Comment thread pkg/auth/factory_test.go
Comment thread pkg/auth/module.go
@slin1237 slin1237 force-pushed the multi-cloud-auth/interface branch from 41c92a0 to 46e77d3 Compare June 30, 2025 18:32
@slin1237
Copy link
Copy Markdown
Collaborator Author

/gemini review

@slin1237 slin1237 force-pushed the multi-cloud-auth/interface branch from 46e77d3 to 55ce315 Compare June 30, 2025 18:33
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a flexible, multi-cloud authentication framework with a factory pattern for creating credentials. The interfaces are well-defined, and the implementation includes support for fallback configurations and dependency injection via fx. My review focuses on improving robustness by preventing infinite recursion in fallbacks, enhancing error diagnostics in the credential chain, and clarifying the fx module usage for better maintainability.

Comment thread pkg/auth/factory.go Outdated
Comment thread pkg/auth/interfaces.go
Comment thread pkg/auth/module.go
@slin1237 slin1237 force-pushed the multi-cloud-auth/interface branch from 55ce315 to 44ee950 Compare June 30, 2025 18:43
@slin1237 slin1237 merged commit 799f857 into main Jun 30, 2025
23 checks passed
@slin1237 slin1237 deleted the multi-cloud-auth/interface branch June 30, 2025 18:51
slin1237 added a commit that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup design documentation Documentation changes feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant