[misc] add oci auth for up, ip, and rp#105
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the project's multi-cloud capabilities by introducing comprehensive support for Oracle Cloud Infrastructure (OCI) authentication. It establishes a new, dedicated OCI authentication module, enabling the system to securely interact with OCI services using various authentication methods, including User Principal, Instance Principal, Resource Principal, and OKE Workload Identity.
Highlights
- New OCI Authentication Module: A dedicated
pkg/auth/ocipackage has been introduced to encapsulate all Oracle Cloud Infrastructure (OCI) specific authentication logic, laying the groundwork for OCI integration. - User Principal Configuration: The
UserPrincipalConfigstruct and associated methods (Validate,ApplyEnvironment) have been added to manage OCI API key-based authentication, supporting configuration file paths, profiles, and session tokens, with robust environment variable overrides. - Generic OCI Credentials Implementation: The
OCICredentialsstruct now implements the project'sauth.Credentialsinterface, handling OCI's unique request signing mechanism (rather than traditional bearer tokens) and providing methods for region retrieval. - OCI HTTP Client for Request Signing: An
OCIHTTPClienthas been provided to simplify making authenticated HTTP requests to OCI services by automatically signing outgoing requests using the configured OCI credentials. - Flexible Authentication Factory: An OCI authentication
Factoryhas been developed, capable of creating credentials for various OCI authentication types: User Principal, Instance Principal, Resource Principal, and OKE Workload Identity, centralizing the credential provisioning process. - Comprehensive Unit Testing: Extensive unit tests have been included for all new OCI authentication components (
config.go,credentials.go,factory.go), ensuring the reliability and correctness of the new authentication features.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces an authentication module for Oracle Cloud Infrastructure (OCI), adding support for User Principal, Instance Principal, and Resource Principal authentication methods. The changes are well-structured. I recommend more robust parsing of environment variables, better error handling, and adjustments to HTTP client parameters.
eceb875 to
ab451e7
Compare
What type of PR is this?
/kind feature
-->
What this PR does / why we need it:
multi cloud support auth module for oci
Which issue(s) this PR fixes:
#100 #101 #102 #103 #94
Fixes #
#100 #101 #102 #103
Special notes for your reviewer:
Does this PR introduce a user-facing change?