[core] Add node affinity for benchmark job pod#428
Merged
slin1237 merged 1 commit intoDec 13, 2025
Conversation
XinyueZhang369
requested review from
CatherineSue,
YouNeedCryDear,
beiguo218,
pallasathena92 and
slin1237
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
benchmark
slin1237
approved these changes
Dec 13, 2025
truddy0
pushed a commit
that referenced
this pull request
Dec 16, 2025
slin1237
pushed a commit
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add node affinity from base model for benchmark job pod if inference service is specified.
Why we need it
In order to ensure the benchmark job pod is scheduled on the node that has the base model.
Fixes #408
How to test
Deployed to mle cluster. now benchmark job pod is scheduled on the right node without hard coded node selector
Checklist
make testpasses locally