Conversation
- Add 40 missing models to values.yaml from config/models - Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs - Total: 196 models now in sync
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to maintain consistency and accuracy within the model definitions for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request synchronizes model configurations by adding 40 new models to values.yaml and removing two obsolete configurations. The changes appear correct and fulfill the PR's objective. My review includes a couple of suggestions to improve vendor name consistency for better maintainability.
| deepseek-r1-zero: | ||
| enabled: false | ||
| createRuntime: true | ||
| vendor: deepseek |
There was a problem hiding this comment.
There's an inconsistency in the vendor field for DeepSeek models. This model uses deepseek, while deepseek-r1 uses deepseek-ai. To maintain consistency and accurately reflect the Hugging Face organization (deepseek-ai), it's recommended to use deepseek-ai as the vendor here. This suggestion also applies to deepseek-v2 and deepseek-v2-5 in this file.
vendor: deepseek-ai| smollm-135m: | ||
| enabled: false | ||
| createRuntime: true | ||
| vendor: huggingface |
There was a problem hiding this comment.
- Add 40 missing models to values.yaml from config/models - Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs - Total: 196 models now in sync
- Add 40 missing models to values.yaml from config/models - Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs - Total: 196 models now in sync
What this PR does
Why we need it
Fixes #
How to test
Checklist
make testpasses locally