Skip to content

[helm] Sync all models between values.yaml and config/models#444

Merged
slin1237 merged 1 commit into
mainfrom
helm-n/6
Dec 14, 2025
Merged

[helm] Sync all models between values.yaml and config/models#444
slin1237 merged 1 commit into
mainfrom
helm-n/6

Conversation

@slin1237
Copy link
Copy Markdown
Collaborator

  • Add 40 missing models to values.yaml from config/models
  • Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs
  • Total: 196 models now in sync

What this PR does

Why we need it

Fixes #

How to test

Checklist

  • Tests added/updated (if applicable)
  • Docs updated (if applicable)
  • make test passes locally

- Add 40 missing models to values.yaml from config/models
- Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs
- Total: 196 models now in sync
@github-actions github-actions Bot added helm Helm chart changes models Model configuration changes config Configuration changes labels Dec 14, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to maintain consistency and accuracy within the model definitions for the ome-serving Helm chart. It updates the values.yaml file by incorporating 40 new model configurations that were previously missing, while simultaneously removing two obsolete model definitions to streamline the configuration and ensure only relevant models are present. This ensures the Helm chart accurately reflects the available and supported models.

Highlights

  • Model Synchronization: Added 40 new model configurations to values.yaml to ensure it is in sync with the config/models directory.
  • Obsolete Model Removal: Removed two outdated model configurations, gpt-oss-120b-bf16 and gpt-oss-20b-bf16, from the config/models directory.
  • Total Models Synchronized: These changes result in a total of 196 models now being consistently defined across the relevant configuration files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request synchronizes model configurations by adding 40 new models to values.yaml and removing two obsolete configurations. The changes appear correct and fulfill the PR's objective. My review includes a couple of suggestions to improve vendor name consistency for better maintainability.

deepseek-r1-zero:
enabled: false
createRuntime: true
vendor: deepseek
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency in the vendor field for DeepSeek models. This model uses deepseek, while deepseek-r1 uses deepseek-ai. To maintain consistency and accurately reflect the Hugging Face organization (deepseek-ai), it's recommended to use deepseek-ai as the vendor here. This suggestion also applies to deepseek-v2 and deepseek-v2-5 in this file.

    vendor: deepseek-ai

smollm-135m:
enabled: false
createRuntime: true
vendor: huggingface
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The vendor huggingface is too generic. Since the model is from the HuggingFaceTB organization on Hugging Face, consider using a more specific vendor like huggingfacetb for better clarity and to avoid potential naming conflicts. This also applies to smollm-360m.

    vendor: huggingfacetb

@slin1237 slin1237 merged commit 9d1ed38 into main Dec 14, 2025
29 checks passed
@slin1237 slin1237 deleted the helm-n/6 branch December 14, 2025 18:11
truddy0 pushed a commit that referenced this pull request Dec 16, 2025
- Add 40 missing models to values.yaml from config/models
- Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs
- Total: 196 models now in sync
slin1237 added a commit that referenced this pull request Dec 22, 2025
- Add 40 missing models to values.yaml from config/models
- Remove obsolete gpt-oss-120b-bf16 and gpt-oss-20b-bf16 configs
- Total: 196 models now in sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration changes helm Helm chart changes models Model configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant