[ci] fix release#87
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the project's README.md to reflect changes in the recommended installation procedures. It introduces OCI registry-based Helm chart installation as the new primary method and standardizes existing Helm repository instructions to use helm upgrade --install. These changes aim to provide more robust and up-to-date guidance for users deploying OME, aligning with potential fixes or improvements in the release process.
Highlights
- Installation Instructions Update: The
README.mdhas been significantly updated to provide clearer and more structured installation instructions for OME. - OCI Registry Support: Introduced 'Option 1: OCI Registry (Recommended)' for installing OME Helm charts directly from
ghcr.io/moirai-internal, leveraging OCI support in Helm. - Helm Command Standardization: Updated all Helm installation commands from
helm installtohelm upgrade --installfor both CRDs and resources, ensuring idempotent installations. - Improved Readability: Reorganized installation methods into distinct, clearly labeled sections: OCI Registry, Helm Repository, and Install from Source, enhancing user guidance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the installation instructions in the README file to feature OCI registry installation as the recommended method and makes the helm commands idempotent. My review identifies a potential issue with the provided OCI registry URL, which appears to point to an internal repository, likely making it inaccessible to the public. I've suggested a correction.
| helm upgrade --install ome-crd oci://ghcr.io/moirai-internal/charts/ome-crd --namespace ome --create-namespace | ||
|
|
||
| # Install OME resources | ||
| helm upgrade --install ome oci://ghcr.io/moirai-internal/charts/ome-resources --namespace ome |
There was a problem hiding this comment.
The OCI registry URL appears to reference an internal organization (moirai-internal). For a public project hosted under the sgl-project organization, this URL should likely point to a public registry within that same organization on GHCR. Using an internal URL in public documentation will likely cause installation to fail for users outside your organization.
I've suggested a more conventional URL structure, but please verify the correct public path for your charts.
| helm upgrade --install ome-crd oci://ghcr.io/moirai-internal/charts/ome-crd --namespace ome --create-namespace | |
| # Install OME resources | |
| helm upgrade --install ome oci://ghcr.io/moirai-internal/charts/ome-resources --namespace ome | |
| helm upgrade --install ome-crd oci://ghcr.io/sgl-project/charts/ome-crd --namespace ome --create-namespace | |
| # Install OME resources | |
| helm upgrade --install ome oci://ghcr.io/sgl-project/charts/ome-resources --namespace ome |
1 participant
No description provided.