Add maven build#1
Conversation
|
|
| @@ -1,4 +1,4 @@ | |||
| Copyright (C) 2005 - 2017 Open Microscopy Environment: | |||
| Copyright (C) 2005 - 2016 Open Microscopy Environment: | |||
| - oraclejdk8 | ||
| - openjdk7 | ||
|
|
||
| matrix: |
There was a problem hiding this comment.
As we are jointly reviewing ome/ome-common-java#11, can you add a temporary step, cloning and installing this SNAPSHOT version to get Travis passing. Once we cut a new ome-common release, we can drop this step and consume the release version.
|
|
||
| <groupId>org.openmicroscopy</groupId> | ||
| <artifactId>ome-codecs</artifactId> | ||
| <version>6.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
As we are changing the groupId/artifactId didn't we decide on going to 0.1.0-SNAPSHOT for now?
There was a problem hiding this comment.
It predated that discussion. For ome-jai we picked 0.1.0 because we don't intend to have it reach a 1.0.0 release. But this component will be immediately used and consumed by bioformats and is already stable; I've set it to 1.0.0-SNAPSHOT for that reason; I can set it to 0.1.0-SNAPSHOT if there's value to make a release before bumping to 1.0.0, but I don't see use for that at present.
There was a problem hiding this comment.
Two thoughts here. For our immediate integration target, my preference is to release a 0.1.0 version which we can consume and wrap in Bio-Formats. That way if anything needs to be discussed, modified and/or adjusted, we can iterate quickly over 0.x.0 releases.
In the mid-run, once the integration is complete, we should definitely look into our roadmap towards a stable 1.0.0 for each of these decoupled components. I would drive this decision via our weekly meetings and make sure we collectively agree on whether we are happy with the state of the API as it stands or there is any breaking change we will have to consider in the next year or so.
| <version>6.0.0-SNAPSHOT</version> | ||
|
|
||
| <name>OME Common Java</name> | ||
| <description>Contains common I/O, date parsing, and XML processing classes.</description> |
| <email>ome-devel@lists.openmicroscopy.org.uk</email> | ||
| </developer> | ||
| </developers> | ||
| <contributors> |
There was a problem hiding this comment.
Does this contributor list need to be adjusted for this component?
There was a problem hiding this comment.
I have done so, though updating it from the git shortlog is a bit manual. Does this section have much value when the information is already in git?
| </prerequisites> | ||
|
|
||
| <scm> | ||
| <connection>scm:git:https://github.com/ome/ome-codecs-java</connection> |
| <connection>scm:git:https://github.com/ome/ome-codecs-java</connection> | ||
| <developerConnection>scm:git:git@github.com:ome/ome-codecs-java</developerConnection> | ||
| <tag>HEAD</tag> | ||
| <url>http://github.com/ome/ome-codecs-java</url> |
| <url>https://ci.openmicroscopy.org/</url> | ||
| </ciManagement> | ||
|
|
||
| <repositories> |
There was a problem hiding this comment.
This section should be unnecessary as the component and its dependencies will be on the Central Repository
| </distributionManagement> | ||
|
|
||
| <dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
Most of the dependencies here are inherited from ome-common-java, can we simply reduce this to ome-common, ome-jai, lwf-stubs and testng?
There was a problem hiding this comment.
Yes, I have now done so.
| - Board of Regents of the University of Wisconsin-Madison | ||
| - Glencoe Software, Inc. | ||
| - University of Dundee</organizationName> | ||
| <projectName>Common package for I/O and related utilities</projectName> |
| <version>2.19.1</version> | ||
| <configuration> | ||
| <suiteXmlFiles> | ||
| <suiteXmlFile>src/test/java/ome/codecs/utests/testng.xml</suiteXmlFile> |
There was a problem hiding this comment.
Not a blocker at all but we can probably drop the utests namespace at some point.
There was a problem hiding this comment.
Yes. This applies to all our repos.
|
I've pushed fixes for most of the comments. |
|
Cut the release of upstream |
|
Now green. |
|
The last commit reads fine to me and passes Travis. #1 (comment) remains to be addressed but this can be carried out in a separate PR together with the update of the headers using the Maven license plugin. Merging this and I will start listing the various cleanup items. |
3 participants
Adds maven build infrastructure. Versions and names can be adjusted as necessary.
Note that Travis will remain red until ome/ome-common-java#11 is merged and we can bump the ome-common dependency. You can test by hand by building ome-common with that PR merged, and then building ome-codecs.