Update paths and add maven build system#1
Update paths and add maven build system#1sbesson merged 18 commits intoome:masterfrom rleigh-codelibre:update-paths
Conversation
|
|
||
| <groupId>org.openmicroscopy</groupId> | ||
| <artifactId>ome-common</artifactId> | ||
| <version>6.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
One question here is whether we should not be conservative and target this as 5.3.0-SNAPSHOT. As far as I know, our first target is a Maven release with no API change and for consumers the major change is the usage of a different groupId/artifactId (and only if they are declaring it directly in their POM).
There was a problem hiding this comment.
This would certainly make sense.
rleigh-codelibre
changed the title
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
Discussed with @rleigh-codelibre, there are a couple of follow-up items after this PR. Some of them are commented inline. In addition, we might want to restore findbugs:checkand activatejavadoc` in the Travis build but both additions will require some code adjustements and should be carried out separately. Fixing these could be natural targets for a 5.3.1 release.
Any other comment/thought/suggestion @melissalinkert @joshmoore @mtbc
| components/*/utils/*.class | ||
| emailable-report.html | ||
| index.html | ||
| target |
There was a problem hiding this comment.
Is target actually used at all, it might be another legacy of the Ant system.
There was a problem hiding this comment.
It's created by maven; all the generated classes, docs, test results etc. go under here.
There was a problem hiding this comment.
Understood, ignore my comment then.
| </scm> | ||
|
|
||
| <repositories> | ||
| <repository> |
There was a problem hiding this comment.
We might want to remove the OME artifactory links here as nothing should depend on them?
| </snapshotRepository> | ||
| </distributionManagement> | ||
|
|
||
| <developers> |
There was a problem hiding this comment.
The developers list might require a review in a follow-up PR.
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
👍 for restoring this in the correct place as logback initialization is required for some of the DebugToolsTest unit tests
| </plugin> | ||
|
|
||
| <plugin> | ||
| <artifactId>maven-jar-plugin</artifactId> |
There was a problem hiding this comment.
Tested the integration of this component into Bio-Formats on top of ome/bioformats#2608. Looking at the difference between the content of formats-common-5.2.3.jar and ome-common-5.3.0-SNAPSHOT.jar, except for META-INF, the only missing file is service.properties which is currently required for using the services.
There was a problem hiding this comment.
This is now added.
|
This PR can be tested functionally using https://github.com/rleigh-codelibre/bioformats/tree/common-split Run |
|
Thanks for the instructions. Using the HEAD of this PR and building successfully |
2 participants
The aim of this PR is to take the result of
git filter-branchin ome-common-java, which is currently not buildable, and to make it build and test with maven, and also do the same driven by travis. This will get the repository functional and testable so that this basic infrastructure will be in place for future PRs.NB. maven builds needs further work either in this PR or as a followup. The
pom.xmlis an aggregate of the logic incomponents/formats-commonand the toplevel. Some of the logic is redundant, and some is likely outdated and unnecessary.