Replace Minio dependency with a service#39
Conversation
melissalinkert
left a comment
There was a problem hiding this comment.
Minor comments aside, I don't see any obvious issues reading through this. Leaving @sbesson to conduct functional tests as discussed.
|
@melissalinkert @mtbc Thanks for reviewing, I've updated this PR |
|
Initial testing based on the state of 3a59777 looked good. In a Fiji distribution with indivually replaced JARs including the new As additional commits have been pushed since, in #39 (commits), re-testing will have to be performed with a new build including the last changes. Looks promising. |
sbesson
left a comment
There was a problem hiding this comment.
Retested using a local Fiji application with manually modified JARs including ome-common-6.0.0-SNAPSHOT with this PR included
Opening images from various formats using the Bio-Formats importer works as expected i.e. the error message reported in ome/bio-formats-fiji#19 (comment) is no longer thrown immediately after selecting the file and both metadata and pixel data are read as expected.
I have not tested the workflow with minio included pointing to a remote location on s3 but from a functional perspective, the addition of the service is sufficient to preserve the current statu quo in terms of deployment of the Bio-Formats plugin in the Fiji ecosystem.
Assuming @mtbc and @melissalinkert are also happy with the last couple of changes, this should be ready to merge and release ome-common 6.0.0.

Replaces the Minio client dependency with an optional service. See https://trello.com/c/UJGyYSrg/129-s3-and-imagej
Testing: check you can run bioformats without Minio.