Bump joda-time and guava versions#92
Merged
melissalinkert merged 1 commit intoome:masterfrom Oct 9, 2024
Merged
Conversation
melissalinkert
approved these changes
Oct 8, 2024
Member
Author
|
@melissalinkert should we get this and #91 in a patch release of |
Member
Yes, I think that makes sense. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ome/bioformats#4245
The 5.6.0 release
cdm-coreupgrades several third-party dependencies includingjoda-timeandguavawhich are bumped to patch releases.Due to the combination of the Maven dependency mechanism which uses
nearest definitionand the order of the dependencies in thepom.xml, these upgraded versions are currently excluded from the Maven build.This is not necessarily an issue per se but causes some problems down the line when OMERO is built with a development version of Bio-Formats in the OME CI -see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/197/
From past experience, the workaround with the current build system is to enforce the dependencies declared in this low-level component are consistent with the one resolved by Maven and Ivy. Additionally, this should enforce that Bio-Formats is shipped with the correct versions.