Review developers section of the parent POM#15
Merged
sbesson merged 2 commits intoome:masterfrom Dec 6, 2016
Merged
Conversation
| <contributor><name>Helen Flynn</name></contributor> | ||
| <contributor><name>David Gault</name></contributor> | ||
| <contributor><name>Alexander Görtz</name></contributor> | ||
| <contributor><name>Mark Hinerm</name></contributor> |
Member
There was a problem hiding this comment.
This should be Mark Hiner
mtbc
reviewed
Dec 6, 2016
| <picUrl>http://loci.wisc.edu/files/loci/images/people/curtis-2010.jpg</picUrl> | ||
| </properties> | ||
| <name>The OME Team</name> | ||
| <email>ome-devel@lists.openmicroscopy.org.uk</email> |
Member
There was a problem hiding this comment.
maybe we want <url>, <organization>, <organizationUrl> too ?
(I assume the <id>'s optional.)
Member
Author
There was a problem hiding this comment.
Some of this is already defined in the organization section above in the POM but I can add minimal information.
Member
There was a problem hiding this comment.
Aha, true! I wonder if we can simply put an <organization> up there to at least name the Open Microscopy Environment but either way this PR is fine to merge.
mtbc
approved these changes
Dec 6, 2016
Member
|
Aha, now found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post components decoupling, this PR reviews the developers to use the following conventions discussed with @jburel and @joshmoore: