Skip to content

kymograph_script_getDataset#111

Merged
joshmoore merged 1 commit intoome:developfrom
will-moore:kymograph_script_getDataset
Apr 21, 2016
Merged

kymograph_script_getDataset#111
joshmoore merged 1 commit intoome:developfrom
will-moore:kymograph_script_getDataset

Conversation

@will-moore
Copy link
Copy Markdown
Member

Fixes https://trac.openmicroscopy.org/ome/ticket/13209

To test:

  • Run kymograph script against an image in 0, 1 or more Datasets.
  • Script should complete and new image placed in one of the same Datasets as original

@will-moore will-moore changed the title Fix image.getDataset() in kymograph.py kymograph_script_getDataset Apr 18, 2016
@joshmoore
Copy link
Copy Markdown
Member

PR which dropped the deprecated method: ome/openmicroscopy#4266

@pwalczysko
Copy link
Copy Markdown
Member

Tested on cowfish connected to eel merge, on an image within 1 dataset, within 2 datasets (copied) and an orphaned image.
All three cases were working as expected.
Ready to merge.

@joshmoore
Copy link
Copy Markdown
Member

Merging. @will-moore : do you want to open the PR to bump the scripts submodule?

@joshmoore joshmoore merged commit 1de4a24 into ome:develop Apr 21, 2016
@will-moore
Copy link
Copy Markdown
Member Author

@joshmoore I can try!.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants