Skip to content

Robot structure#1473

Merged
jburel merged 98 commits intoome:dev_4_4from
jburel:robot-structure
Sep 16, 2013
Merged

Robot structure#1473
jburel merged 98 commits intoome:dev_4_4from
jburel:robot-structure

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Sep 11, 2013

To review that PR.

  • Make sure the following top-level commands work clean, build default, test-unit
  • For test-unit, check that the unit tests under components/test/ui/java are executed.
  • For the UI tests themselves, the daily OMERO-merge-robotframework-stable build should be green.

The commands clean and build default are also run as part of the daily OMERO-merge-robotframework-stable build.

If you wish to run the tests locally and try the various ant target, please follow instructions in README. Robot framework and jython must be installed.
Note that if you wish to run the ant setup-db target, you must run test-compile.

The CLI section is mainly to have the structure in place. Another Robot library (Process) will be used.

This PR replaces gh-1424

mtbc and others added 30 commits September 11, 2013 08:28
these are very much work-in-progress but may be helpful
get thumbnail border color
get thumbnail canvas image hash
shows synchronization between tree view and data browser selection
obviates unfortunate need for sleep in test case script
this will break the build for now, hopefully somebody competent
will fix it
Conflicts:
	components/tests/ui/testcases/insight/experiments/test-11210.rest
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Sep 11, 2013

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Sep 12, 2013

@sbesson
Copy link
Copy Markdown
Member

sbesson commented Sep 12, 2013

Locally ran /build.py build-default test-compile && ./build.py test-unit. Output of the test included the UI tests being run as expected:

Entering /Users/sebastien/code/ome/openmicroscopy/components/tests/ui...

test:
Entering /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java...

testng-init:
:: Ivy 2.1.0 - 20090925235825 :: http://ant.apache.org/ivy/ ::
:: loading settings :: file = /Users/sebastien/code/ome/openmicroscopy/etc/ivysettings.xml
    conflict on /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java/target/libs/test/guava-jdk5.jar in [test]: 13.0 won

test-compile:
Deleting: /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java/target/java-ui-libraries-test.xml
:: loading settings :: file = /Users/sebastien/code/ome/openmicroscopy/etc/ivysettings.xml
:: delivering :: omero#java-ui-libraries-test;working@sbesson.bio.ed.ac.uk :: 4.4.8-DEV-ice34 :: integration :: Thu Sep 12 15:59:49 BST 2013
    delivering ivy file to /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java/target/java-ui-libraries-test.xml
:: publishing :: omero#java-ui-libraries-test
    published java-ui-libraries-test to /Users/sebastien/code/ome/openmicroscopy/etc/../target/test-repository/java-ui-libraries-test-4.4.8-DEV-ice34.jar
    published ivy to /Users/sebastien/code/ome/openmicroscopy/etc/../target/test-repository/java-ui-libraries-test-4.4.8-DEV-ice34.ivy

test:
Entering /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java...

test-suite:
[TestNG] Running:
  /Users/sebastien/code/ome/openmicroscopy/components/tests/ui/library/java/test/unit.testng.xml
===============================================
UI scripts unit tests
Total tests run: 4, Failures: 0, Skips: 0
===============================================

Additionally, OMERO-merge-robotframework-stable#76 passes while calling

./build.py -f components/tests/ui/build.xml -Dtest.with.fail=true test-all

For the job itself, we may want to parse the XML output stored into components/tests/ui/target/reports/**/*.xml in preparation of upcoming tests.

With regard to all these elements, ready to merge.

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Sep 12, 2013

@sbesson: This will happen in another PR (PR is big enough). cf. coming Tuesday presentation.
i.e.
Add daily build for all components (web)
Publish the outputs and logs generated

Comment thread components/tests/ui/build.xml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome to remove this bit if you want. 😄

@joshmoore
Copy link
Copy Markdown
Member

Other than my very minor comments, 👍 (Merge at will)

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Sep 13, 2013

License is Apache License, Version 2.0. So we are okay.
I will fix the build file. Must have been a copy paste from another file.

jburel added a commit that referenced this pull request Sep 16, 2013
@jburel jburel merged commit 79b23d4 into ome:dev_4_4 Sep 16, 2013
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Sep 16, 2013

--rebased-to #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants